×

Notice

The forum is in read only mode.
Welcome, Guest
Username: Password: Remember me
  • Page:
  • 1
  • 2

TOPIC: !JoomlaComment 4.1 alpha1

!JoomlaComment 4.1 alpha1 7 years 11 months ago #7814

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar Topic Author
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 154
  • Thank you received: 1081
Subscribe for this thread if you wish to help when the new version of joomlacomment is ready!
Thanks in advance!

!JoomlaComment 4.1 alpha1 7 years 11 months ago #7815

  • Alain Rivest
  • Alain Rivest's Avatar
  • Offline
  • Fresh Boarder
  • Fresh Boarder
  • Posts: 14
  • Thank you received: 0
I'll be glad to test the new version! B)

!JoomlaComment 4.1 alpha1 7 years 11 months ago #7845

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar Topic Author
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 154
  • Thank you received: 1081
Hey Alain,
Thanks for the wish to help. I'm still working on the installation script. I should be ready tomorrow :)

!JoomlaComment 4.1 alpha1 7 years 11 months ago #7856

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar Topic Author
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 154
  • Thank you received: 1081
Here we go :)

This version includes only the english language files. All other language php files should be updated to ini files (this will happen in the next release)

This version includes only the modern template, since this is the only one that doesn't produce any errors. The other templates should be updated in the next release.

This version should be able to update from joomlacomment 4.0. But please be careful. Make a backup first, don't test on production sites! Once you update to 4.1 you will not be able to return to 4.0 without manually executing sql queries in the database.

What do I want to achieve with this version. The backend and the frontend have nothing to do with 4.0! The code is structured, organized better and cleaner! Functions that were not used and were in the package only for legacy purposes are removed from the package.

This version should also be faster. (read my blogpost: compojoom.com/blog/8-news/101-alpha-testers-needed#CommentForm ) Less queries to the database => faster loading times.

Please test carefully the backend and the frontend - let us find all bugs and fix them for the next version!

Plan for the next version:
1. include all language files
2. include all templates
3. work on some javascript problems
4. fix all bugs that we may encounter in this alpha release

edit: find the attachment in my next post.

!JoomlaComment 4.1 alpha1 7 years 11 months ago #7857

  • Alain Rivest
  • Alain Rivest's Avatar
  • Offline
  • Fresh Boarder
  • Fresh Boarder
  • Posts: 14
  • Thank you received: 0
I will install it on my test site and let you know how it goes.

!JoomlaComment 4.1 alpha1 7 years 11 months ago #7860

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar Topic Author
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 154
  • Thank you received: 1081
Nice Alain, but the first bug catch goes to me :D
I was improving the query syntax once I released that for some reason I can not edit my post :)
the fix is here #303:
dev.compojoom.com/repositories/revision/jocomment/303

!JoomlaComment 4.1 alpha1 7 years 11 months ago #7861

  • Alain Rivest
  • Alain Rivest's Avatar
  • Offline
  • Fresh Boarder
  • Fresh Boarder
  • Posts: 14
  • Thank you received: 0
I started testing, here's what I found :

Missing spaces in installation message :

DATABASEcomment_settingUPDATED

DATABASEcommentUPDATED

INSTALLED THE CONTENT PLUGIN

ENABLED THE CONTENT PLUGIN


Error when I click on the link "Write a comment" from the front page :
( ! ) Fatal error: Call to undefined method JOSC_utils::utf8_wordwrap() in /var/www/vivahate/components/com_comment/joscomment/utils.php on line 324
Call Stack
#	Time	Memory	Function	Location
1	0.0003	74964	{main}( )	../index.php:0
2	0.2498	7970444	JSite->dispatch( )	../index.php:68
3	0.2621	8213288	JComponentHelper->renderComponent( )	../application.php:124
4	0.2718	8310052	require_once( '/var/www/vivahate/components/com_content/content.php' )	../helper.php:162
5	0.2778	8645564	JController->execute( )	../content.php:35
6	0.2778	8645564	ContentController->display( )	../controller.php:236
7	0.2817	8888188	JController->display( )	../controller.php:48
8	0.2936	9314304	ContentViewArticle->display( )	../controller.php:310
9	0.5907	12060236	JDispatcher->trigger( )	../view.html.php:102
10	0.6108	12172068	call_user_func_array ( )	../dispatcher.php:136
11	0.6108	12172068	pluginJosCommentJ15( )	../dispatcher.php:0
12	0.6108	12172068	pluginJosComment( )	../joscomment.php:47
13	0.6113	12184440	require( '/var/www/vivahate/administrator/components/com_comment/plugin/com_content/josc_com_content.php' )	../joscomment.php:58
14	0.6118	12184936	JOSC_utils::execJoomlaCommentPlugin( )	../josc_com_content.php:44
15	0.6329	12347176	JOSC_visual->visual_htmlCode( )	../utils.php:72
16	0.6442	12368420	JOSC_visual->insertComments( )	../JOSC_visual.php:467
17	0.6442	12368420	JOSC_visual->getComments( )	../JOSC_visual.php:289
18	0.6528	12388844	JOSC_visual->insertPost( )	../JOSC_visual.php:264
19	0.6583	12394248	JOSC_post->post_htmlCode( )	../JOSC_visual.php:112
20	0.6598	12394896	JOSC_post->parseUBBCode( )	../JOSC_post.php:344
21	0.6598	12395184	JOSC_ubbcode->ubbcode_parse( )	../JOSC_post.php:252
22	0.6598	12395184	JOSC_ubbcode->parseUBB_withlimit( )	../JOSC_ubbcode.php:336
23	0.6617	12397944	JOSC_utils->wrapText( )	../JOSC_ubbcode.php:106

!JoomlaComment 4.1 alpha1 7 years 11 months ago #7862

  • Alain Rivest
  • Alain Rivest's Avatar
  • Offline
  • Fresh Boarder
  • Fresh Boarder
  • Posts: 14
  • Thank you received: 0
I have the same error when trying to post a comment in an article with no comment.
Fatal error: Call to undefined method JOSC_utils::utf8_wordwrap() in /var/www/vivahate/components/com_comment/joscomment/utils.php

!JoomlaComment 4.1 alpha1 7 years 11 months ago #7863

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar Topic Author
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 154
  • Thank you received: 1081
I've removed that function right before I made the package for the alpha, but this function was not used. Let me check.

!JoomlaComment 4.1 alpha1 7 years 11 months ago #7864

  • Alain Rivest
  • Alain Rivest's Avatar
  • Offline
  • Fresh Boarder
  • Fresh Boarder
  • Posts: 14
  • Thank you received: 0
This forum keeps giving me 404 error. I think it happens after a new post, it redirect to show the new post, when I click reply to post a new message I get a 404 error.

!JoomlaComment 4.1 alpha1 7 years 11 months ago #7865

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar Topic Author
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 154
  • Thank you received: 1081
Sorry about that. I'm trying to configure 404sef. I'll set the site offline in the next hour.

!JoomlaComment 4.1 alpha1 7 years 11 months ago #7866

  • Alain Rivest
  • Alain Rivest's Avatar
  • Offline
  • Fresh Boarder
  • Fresh Boarder
  • Posts: 14
  • Thank you received: 0
Ha ok, it make sens now!

I found another one: On the admin side, the link "importcomment" give this error :

500 - An error has occurred.

Layout "default_Mapping" not found

!JoomlaComment 4.1 alpha1 7 years 11 months ago #7867

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar Topic Author
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 154
  • Thank you received: 1081
I remember that I wrote the function utf8_wordwrap in the past, but at the moment I really don't understand why we have wordwrap and utf8_wordwrap.

open utils.php and add this code
	/**
	 * utf-8 aware Wordwrap
	 *
	 * http://milianw.de/code-snippets/utf-8-wordwrap
	 *
	 * @edit Daniel Dimitrov - using Joomla's JString class instead of the mb functions
	 */
 
	function utf8_wordwrap($str, $width=75, $break="\n", $cut=false) {
		$splitedArray    = array();
		$lines            = explode("\n", $str);
		foreach ($lines as $line) {
			$lineLength = JString::strlen($line);
 
			if ($lineLength >= $width) {
				$words = explode("\040", $line);
				$lineByWords = '';
				$addNewLine = true;
				foreach ($words as $word) {
					$lineByWordsLength    = JString::strlen($lineByWords);
					$tmpLine              = $lineByWords.((JString::strlen($lineByWords) !== 0) ? ' ' : '').$word;
					$tmplineByWordsLength = JString::strlen($tmpLine);
					if ($tmplineByWordsLength > $width && $lineByWordsLength <= $width && $lineByWordsLength !== 0) {
						$splitedArray[]   = $lineByWords;
						$lineByWords    = '';
					}
 
					$newLineByWords            = $lineByWords.((JString::strlen($lineByWords) !== 0) ? ' ' : '').$word;
					$newLineByWordsLength    = JString::strlen($newLineByWords);
					if ($cut && $newLineByWordsLength > $width) {
						for ($i = 0; $i < $newLineByWordsLength; $i = $i + $width) {
							$splitedArray[] = JString::substr($newLineByWords, $i, $width);
						}
						$addNewLine = false;
					} else {
						$lineByWords = $newLineByWords;
					}
				}
				if ($addNewLine) {
					$splitedArray[] = $lineByWords;
				}
			} else {
				$splitedArray[] = $line;
			}
		}
		return implode($break, $splitedArray);
	}

this should make the error while posting disappear.

!JoomlaComment 4.1 alpha1 7 years 11 months ago #7868

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar Topic Author
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 154
  • Thank you received: 1081

I found another one: On the admin side, the link "importcomment" give this error :


how does that link look like?

!JoomlaComment 4.1 alpha1 7 years 11 months ago #7869

  • Alain Rivest
  • Alain Rivest's Avatar
  • Offline
  • Fresh Boarder
  • Fresh Boarder
  • Posts: 14
  • Thank you received: 0
I added the function, now it's working.

The importcomment link is :
http://localhost/vivahate/administrator/index.php?option=com_comment&view=import

It's in the admin menu.

!JoomlaComment 4.1 alpha1 7 years 11 months ago #7870

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar Topic Author
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 154
  • Thank you received: 1081
would you try the attached version. Just uninstall and install this one. joomlacomment4-20091115.zip

!JoomlaComment 4.1 alpha1 7 years 11 months ago #7871

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar Topic Author
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 154
  • Thank you received: 1081
LOL, I managed to install !joomlacomment 4.1 alpha1 one joomla 1.6 alpha1 without any problems :)

Yea, it is not working after that, but with few code changes we will have a version working on joomla 1.6, yaaahoooooo!

!JoomlaComment 4.1 alpha1 7 years 11 months ago #7872

  • Alain Rivest
  • Alain Rivest's Avatar
  • Offline
  • Fresh Boarder
  • Fresh Boarder
  • Posts: 14
  • Thank you received: 0
That's good news! :)

I installed the last version, and I found bugs with the emoticon.
The "silly" and "side" emoticon doesn't work. Looks like the code for ":s" should be after...

!JoomlaComment 4.1 alpha1 7 years 11 months ago #7882

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar Topic Author
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 154
  • Thank you received: 1081
Is the backend working?

!JoomlaComment 4.1 alpha1 7 years 11 months ago #7883

  • Alain Rivest
  • Alain Rivest's Avatar
  • Offline
  • Fresh Boarder
  • Fresh Boarder
  • Posts: 14
  • Thank you received: 0
Yes, except for the "importcomment" link.
  • Page:
  • 1
  • 2
Time to create page: 0.181 seconds