Joomcomment 4 with sh404sef

Joomcomment 4 with sh404sef 14 years 9 months ago #5251

fxandrei Topic Author Offline Fresh Boarder Posts: 11 Thank you received: 0	I have o problem. The links that get generated for the comments (from the module) are not correct. And dont get anywhere if i click on them. Is there a solution to make it work ? How about if i set sh404 to not make links for the module ? Can i do that ? Cuz i tryed and didnt work. Check this box to be notified of replies to this topic. Note: BBcode and smileys are still usable.

Joomcomment 4 with sh404sef 14 years 9 months ago #5347

fxandrei Topic Author Offline Fresh Boarder Posts: 11 Thank you received: 0	Some one please help. At least tell me where to look. Maybe o can force sh404 sef to skip making links for this module. Check this box to be notified of replies to this topic. Note: BBcode and smileys are still usable.

Joomcomment 4 with sh404sef 14 years 9 months ago #5355

fxandrei Topic Author Offline Fresh Boarder Posts: 11 Thank you received: 0	it worked with artio, for now. But how about a plugin for the module ? can i find something like this ? Check this box to be notified of replies to this topic. Note: BBcode and smileys are still usable.

Joomcomment 4 with sh404sef 14 years 9 months ago #5366

Daniel Dimitrov Offline Administrator Posts: 9618 Karma: 155 Thank you received: 1081	Hey there guys, I'm trying to find a solution for that, but I'm not getting any help from sh404sef developers: extensions.siliana.com/forums/index.php?...30.msg20578#msg20578 Check this box to be notified of replies to this topic. Note: BBcode and smileys are still usable.

Joomcomment 4 with sh404sef 14 years 8 months ago #5424

JonusC
Offline
Platinum Boarder
Posts: 785
Thank you received: 48

I have no problem at all with JoComment and sh404SEF. The links arn't *completely* SEF-translated, but everything works fine.

I have an Apache server and am using .htaccess enabled mod_rewrite method. Make sure you setup the sh404SEF component fully by modifying your .htaccess file too as described in it's documentation.

I also installed sh404SEF as the very first thing on my site, before any other extensions. I also have anti-flood set to period 10/requests 10 which I find is a good trade-off between false blocking but still protecting from phreaking and DDoS attacks.

EDIT: Ignore my entire post - I didn't realize this was a problem with the Module

Joomcomment 4 with sh404sef 14 years 8 months ago #5538

Gekko
Offline
Fresh Boarder
Posts: 2
Thank you received: 0

Hi all,
i downloaded your component and is very nice!!!

I used this trick to solve this problem:

use / instead # in the bar when you create the link.

Try and tell us where we can do this change in php files.
I will search now for it, but better you explain to all how to do.

Greetings,
Gekko.
www.playfaster.net

Joomcomment 4 with sh404sef 14 years 8 months ago #5539

Gekko
Offline
Fresh Boarder
Posts: 2
Thank you received: 0

Ok, found the file:

go to component/com_jcomments/tpl/default
change # with /

switch($style) {
			case -1:
				return '<span class="comment-link">'.JText::_('COUNT').' ('.$count.')</span>';
				break;
			case 0: 
				return '<a href="'.$link.'/addcomments" class="comment-link">'.JText::_('WRITE').'</a>';
				break;
			default:
				return '<a href="'.$link.'/comments" class="comment-link">'.JText::_('COUNT').' ('.$count .')</a>';
				break;
		}

Worked for me.
Enjoy!!

Joomcomment 4 with sh404sef 14 years 8 months ago #5540

fxandrei Topic Author Offline Fresh Boarder Posts: 11 Thank you received: 0	i dont have that dir. mine is com_comments. and i cannot fing tpl Check this box to be notified of replies to this topic. Note: BBcode and smileys are still usable.

Joomcomment 4 with sh404sef 14 years 8 months ago #5564

Daniel Dimitrov Offline Administrator Posts: 9618 Karma: 155 Thank you received: 1081	Gekko - you are talking about jomcomment and we are talking about joomlacomment. although I don't understand the sense behind what you are saying. Why should removing #, which is an anchor and is left untouched from the JRoute function be transformed to / for 404SEF? Could you please explain? Check this box to be notified of replies to this topic. Note: BBcode and smileys are still usable.

Joomcomment 4 with sh404sef 14 years 8 months ago #6013

miooh Offline Fresh Boarder Posts: 6 Thank you received: 0	Hello Daniel, Did you resolve this problem? My website isn't the same without your plugin... ... sorry for my English... Check this box to be notified of replies to this topic. Note: BBcode and smileys are still usable.

Joomcomment 4 with sh404sef 14 years 8 months ago #6054

Daniel Dimitrov Offline Administrator Posts: 9618 Karma: 155 Thank you received: 1081	hey miooh, Nope, I didn't work on this, because I don't get any feedback from the 404sef developers. I don't know what is wrong and since there is no developer guide for 404sef I can not make something more than hit my head against the wall Check this box to be notified of replies to this topic. Note: BBcode and smileys are still usable.

Joomcomment 4 with sh404sef 14 years 8 months ago #6207

taro yamada
Offline
Fresh Boarder
Posts: 1
Thank you received: 0

Well, preliminary way, I did.

1. Find this file.
****/modules/mod_comments/mod_comments/mod_comments.class.php

2. Find line.

$link = $comObject->linkToContent($post->_item['contentid'], $post->_item['id'], true);

3. Edit this.

//		$link = $comObject->linkToContent($post->_item['contentid'], $post->_item['id'], true);
 
		$link = JRoute::_(ContentHelperRoute::getArticleRoute($post->_item['contentid'], $row->_catids, $row->_secids)) . "#josc" . $post->_item['id'];

I hope this would help...

Joomcomment 4 with sh404sef 14 years 8 months ago #6215

miooh Offline Fresh Boarder Posts: 6 Thank you received: 0	Yeah! it works! Thank you Taro Yamada! It works halfly, but it works! (when I click on the link, it goes only to the article, but not to the clicked comment) Check this box to be notified of replies to this topic. Note: BBcode and smileys are still usable.

Joomcomment 4 with sh404sef 14 years 8 months ago #6228

JonusC Offline Platinum Boarder Posts: 785 Thank you received: 48	This is good! To make it jump to the Comment, we somehow need to get the Comment ID and pass it as an anchor parameter #josc10 for ID:10 for example... Check this box to be notified of replies to this topic. Note: BBcode and smileys are still usable.

Joomcomment 4 with sh404sef 14 years 8 months ago #6239

miooh
Offline
Fresh Boarder
Posts: 6
Thank you received: 0

As I said.... it works, but...

if you have only one page with comments (for example: only 9 comments = 1 page) it works fine- it goes to linked comment,

but

if you have more than 10 comments (so you have more than one page with comments) it goes to the first page (with the article, and the first 10 comments)

Joomcomment 4 with sh404sef 14 years 7 months ago #6297

JonusC
Offline
Platinum Boarder
Posts: 785
Thank you received: 48

Ah I see.. pagination...

...so now, we need a way for the module to count the number of comments total, then check backend parameters for "How many per page" we've set, then calculate/divise which page the requested comment would be on and adjust the UIRL accordingly. Hmmm I havn't dealt with multiple-paged comments yet, but if Daniel doesn't have time to investigate let me see what I can find (I havn't even seen the module yet!)

Joomcomment 4 with sh404sef 14 years 7 months ago #6515

Dennis
Offline
Fresh Boarder
Posts: 2
Thank you received: 0

This solution, works also for me! But!!!
I have the possiblity on my site for users to submit news on the frontend, but after changing this I get this error when people try to submit news:

Fatal error: Class 'ContentHelperRoute' not found in /var/www/vhosts/scerica.nl/httpdocs/modules/mod_comments/mod_comments/mod_comments.class.php on line 239

Hope somebody has a solution for this! Thanks in advance

Joomcomment 4 with sh404sef 14 years 7 months ago #6516

miooh Offline Fresh Boarder Posts: 6 Thank you received: 0	I found very simple solusion of this problem... I've just uninstalled sh404sef and all problems gone... I've turned on joomla's native simple addresses and it works fine that's all thank you for your help guys Check this box to be notified of replies to this topic. Note: BBcode and smileys are still usable.

Joomcomment 4 with sh404sef 14 years 7 months ago #6517

Dennis
Offline
Fresh Boarder
Posts: 2
Thank you received: 0

miooh wrote:

I found very simple solusion of this problem...
I've just uninstalled sh404sef and all problems gone...
I've turned on joomla's native simple addresses and it works fine
that's all
thank you for your help guys

Well this isn't really a solution. Turning of SEO isn't a option for me (think of search engines and the look of a web-url). Maybe for some it's a solution, but I think a lot don't want to lose the SEF url's.

Joomcomment 4 with sh404sef 14 years 7 months ago #6518

miooh Offline Fresh Boarder Posts: 6 Thank you received: 0	I didn't lose SEF urls... it's an example: http://***/index.php/aktualnosci/495-beda-pieniadze--**********-szpitala.html that's only joomla's simple adresses, and adresses with .html. I don't use mod_rewrite, so there is index.php... but the rest- I think it's ok Check this box to be notified of replies to this topic.* Note: BBcode and smileys are still usable.

Tiles

CMC

CMandrill

FFGate

CUpdater

CNotes

Mydigipass

CSlideshow

Pricing

Joomla! Development

Joomla! Security

App Development

Angular 2

Official releases

Developer releases

Languages

Help Desk

Support policy

Hotspots

Matukio Events

CComment

Ctransifex

CMC

CNotes

CMigrator

CMandrill

MyDigipass

CForms

CForms for WordPress

Video Tutorials

Changelogs

Matukio API Docs

Team

Joomla Commitment

Privacy Policy / Imprint

Notice

TOPIC: Joomcomment 4 with sh404sef