TOPIC: Error in latest version of Module

I've been having problems with the Module giving incorrect links (back to the home page rather than article) when listing most commented. I'm using sh404sef and tried all the fixes mentioned on the board without luck.

I then got digging in the code and found there is an error in line 80 of mod_comments.class.php

It should read
$id = $row;
not
$id = $row;


I hope this helps.

which joomlacomment version are you using 4.0RC1 ?

Yes, but this error is in the module. I'm using a recent version of the module that you provided on the forum in response to as question.

I checked the contents of the array being passed to the module and it didn't include id, just contentid.

I've tested the fix and it works.

If you look carefully at the module code you will find out that we use code from the component. That is why I asked you if you use RC1.

I realise that. I know that the link is formed in josc_com_content.class.php. But it is the module that wasn't working because the information wasn't being passed correctly.

I do like your product though and I'm posting this to help not to criticise.

Hey Andrew,
I'm not assuming that you are criticizing - I just want to know which version of joomlacomment you are using. I can not remember all the things I've changed to the component. So perhaps this is something solved in RC1. This is why I am asking you if you use the latest version or not.

Sorry, my initial answer was unclear. I did say yes to using RC1 but I can see that wasn't obvious.

Ah good. I'll check it out then, but I have this strange feeling that if I make your change, that it won't work for all other plugins

But the change is only to the module, it doesn't alter the component.

But yes, knock-on effects would not be good!

Forgive me if I missed something, but this makes no sense to me. contentid returns Undefined Index error and the entire module breaks. Please tell us your Joomla version, PHP version and MySQL version, and if you have ever installed any other commenting components as there may be lingering (yComments, JomComment, JComments, etc)

Also tell us if you have done any upgrading on this site (Joomla 1.0 > 1.5, or JoomlaComment 3.26 > 4.0, etc.)

Daniel did you actually try the "fix" in the original post?

EDIT: Do you have one of the outdated versions of sh404SEF installed (all the ones that were free) or are you up to date (paid versions)? If you're up to date please make a screen dump of your settings and I will compare to mine, I can put this in a FAQ about JoomlaComment or sh404SEF.

It's Joomla 1.5.15, PHP 5.2.12, MySQL 5.

No other comment components but I am using an old version of SH404SEF (the final free version). Could this be the issue?

Thinking back, I think the module stopped working when I upgraded your Component to the latest version.

I checked the info being passed to the module and it doesn't include contentid but it does include id. When I changed it to contentid it works.

I did try without SH404SEF running (this was my first thought) and still had the problem.

Thanks for your attention on this. I hope I'm not making a mistake and misunderstood something.

(1) Are these comments (that should be displayed/previewed in your module) from com_content? I.e. standard articles? Or is it a different plugin?

(2) Do you have legacy mode enabled (and any legacy modules/components enabled) out of curiosity? Reason I ask is because some other extensions can freak out with id/contentid mismatching because of that.

(3) Do you have JUGA or JoomlaPack installed?

(4) Can you provide complete screendumps of all your sh404SEF settings?

(5) Are you sure you have JoomlaComment 4.0 RC1 and mod_comments_2010-02-04 installed?

(1) Just com_content.

(2) No.

(3) Joomlapack.

(4) Attached.

(5) Yes, I'm sure.

The image attachment did not work, this forum needs to be fixed up a bit. Can you post direct link(s) instead?

We are still actively trying to diagnose this, thanks for the patience and giving us the chance to investigate Andrew.

EDIT2: Ignore everything below here, I got two threads mixed up though I'm leaving it here instead of deleting it so I remember to check all this out deeper if sh404SEF settings are fine...

I have a hunch this might be JoomlaPack related... although some other transport/entry-point plugins can conflict too. Try going into the backend and disabling all these plugins (if you have them) and test the module:

System - Real Simple Discovery (RSD)
XML-RPC - metaWeblog API
JoomlaPack Remoting XMLRPC services for JoomlaPack 2.x
XML-RPC - Joomla
XML-RPC - Blogger API

EDIT: Do you have UBBCode enabled or disabled (in JoomlaComment)?

Disabling the Plugins didn't help.

UBBCode is off.

Image is here:

Tomorrow I'll try the set up on one of my test sites to see if I have the same problem.

Thanks for your attention and support.

Aha! While I investigate, could you try turning on UBBCode support and clear all cache to make sure that isn't the problem? I have a feeling it is (thanks to a tip in Bug Reports).

If that doesn't work, yeah go ahead and try a fresh test site... then do your own comparisons/testing to make the test site more and more identical to the live site. Should find the cause this way. Yes it's slow but it usually works... and if you can do this (or alternatively send me a complete dump of your website *joke*) we would be very appreciative but try enabling UBBCode first!

OK. Stop everything. Two solutions:

(01) Turn on UBBCode support for now and delete the {BLOCK-_UBBCode}.....{/BLOCK-_UBBCode} from the template index.html file, or;

(02) Use the hotfix contributed, details of code changes are at this thread .

We will address this permanently in an RC2 release.

I've tried that and it doesn't work. I'm beginning to wonder whether you are looking at the right problem because I can't see why these things would affect the problem I had.

Just to reiterate the initial issue. I use the module to display a list of the most commented articles. If I install the component and module as standard and enable the module, the list of articles it produces is correct but the links just point to the top level domain ( www.developingtelecoms.com )without the link being fully formed. I investigated the problem and found that the part of the module that forms the link uses 3 variables $row, $row and $row. So I looked at the array being passed to the code and found it did not pass a value for 'id' but, as I would expect, it did pass 'contentid'. I therefore changed line 80 in mod_comments.class.php to contentid instead of id and the module then worked as expected and the full url was formed.

I'll do some more testing this morning.

I've now proved the problem on a virgin install of Joomla with nothing else installed.

Please note that it is only when listing the most commented articles that this happens. Other functions within the module produce correct URLs.

Ah I'm terribly sorry Andrew, I've been a little stressed lately. Not only did I get your thread mixed up with a completely different bug, but I solved the problem within 30 minutes of reading your last reply. Only it is for 4.1 alpha and I think Daniel has completely re-written it anyway.

We will address it properly in RC2.