×

Notice

The forum is in read only mode.
Welcome, Guest
Username: Password: Remember me
  • Page:
  • 1

TOPIC: after Beta2 ::: still invalid XHTML markup

after Beta2 ::: still invalid XHTML markup 14 years 9 months ago #5949

  • valandis
  • valandis's Avatar Topic Author
  • Offline
  • Fresh Boarder
  • Fresh Boarder
  • Posts: 7
  • Thank you received: 0
Hi there!

I ve just tested the XHTML validity of Beta2 and a simple empty page with the comment form gave me 27 errors and 6 warnings! The template used was the one you suggest to be the most stable one: modern with standard CSS. The last version Alpha3 that I used didnt produce so many errors, but still invalid.

My question is: will these errors be fixed some time in the near future?

Maybe for some people XHTML compliance isnt important at all, but if someone is working with SEO sites it is very important to have valid markup.

Thanks for listening.

after Beta2 ::: still invalid XHTML markup 14 years 9 months ago #5950

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
you must specify the doc type! using the standard joomla template in xhtml transitional the template generates few warnings and that is all.

after Beta2 ::: still invalid XHTML markup 14 years 9 months ago #5951

  • valandis
  • valandis's Avatar Topic Author
  • Offline
  • Fresh Boarder
  • Fresh Boarder
  • Posts: 7
  • Thank you received: 0
Daniel Dimitrov wrote:

you must specify the doc type! using the standard joomla template in xhtml transitional the template generates few warnings and that is all.


The Doctype is of course defined at the beginning of my index.php of the template, which is XHTML Transitional 1.0 (standard JA Purity template). But the component produces many errors like I said before and doesn't validate. That is a bug and imho should be #1 priority to be fixed. I believe there are many ppl out there who would care about XHTML validation, don't you think?

after Beta2 ::: still invalid XHTML markup 14 years 9 months ago #5953

  • JonusC
  • JonusC's Avatar
  • Offline
  • Platinum Boarder
  • Platinum Boarder
  • Posts: 785
  • Thank you received: 48
Could you upload a saved text or HTML file of your Validator Results page for us to take a look at?

after Beta2 ::: still invalid XHTML markup 14 years 9 months ago #5960

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
Valandis, I'm telling you that my localhost installation only produces 6 warnings - and worning is not an error. If you don't give us an url to see the nature of your erros then I can not help you :)

after Beta2 ::: still invalid XHTML markup 14 years 9 months ago #5961

  • JonusC
  • JonusC's Avatar
  • Offline
  • Platinum Boarder
  • Platinum Boarder
  • Posts: 785
  • Thank you received: 48
Daniel Dimitrov wrote:

my localhost installation only produces 6 warnings

When I use JA_Purity and modern CSS, I get the same result. But if I enable the Community Builder login module and switch over to my JavaScript-heavy personal template (still in production), I get over 50 errors and 100 warnings :laugh:

after Beta2 ::: still invalid XHTML markup 14 years 9 months ago #5963

  • valandis
  • valandis's Avatar Topic Author
  • Offline
  • Fresh Boarder
  • Fresh Boarder
  • Posts: 7
  • Thank you received: 0
Guys the bugs are located in the template file of JoomlaComment (the index.html) and in the comment.class.php file.

In file comment.class.php at lines: 2786 - 2792 the alt texts of the images are misinterpreted to something else. For example I changed line 2786 from:
$html = "<a href='javascript:JOSC_insertUBBTag("b")'><img src='" . $ubbIconList['bold'] . "' class='buttonBB' name='bb' alt='[b]' /></a>&nbsp;";
to:
$html = "<a href='javascript:JOSC_insertUBBTag("b")'><img src='" . $ubbIconList['bold'] . "' class='buttonBB' name='bb' alt='Bold' /></a>&nbsp;";
and I did the same for all these lines, I changed the alt texts, since I didn't know where else to look for a solution. This solved almost all the errors I was getting, except one.

One error I couldn't find is when someone makes a "quote" of a comment. The W3C Validator says: Attribute "cite" exists, but can not be used for this element and this appears to be on the line of the quote beginning with:
<div class='yvBBCode_quote' cite="name">text...
The last fix should be to delete this "cite" attribute from the "div", because this is exactly what causes the error. But where is the cite attribute produced in your code, I got no idea; I looked everywhere, but haven't found it.

after Beta2 ::: still invalid XHTML markup 14 years 9 months ago #5966

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
Why is
alt='[b]' 
a problem? the w3 specification says that alt should be text - what is wrong with []? Why tidy don't complain for me???

after Beta2 ::: still invalid XHTML markup 14 years 9 months ago #5967

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
yvBBCode_quote ???????????

Man did you turn your yv comment plugin off????

forum.joomla.org/viewtopic.php?p=1348449...7d8cb011d8c#p1348449


look at the code that the user provided that is yv comment and not !joomlacomment code.

after Beta2 ::: still invalid XHTML markup 14 years 9 months ago #5969

  • valandis
  • valandis's Avatar Topic Author
  • Offline
  • Fresh Boarder
  • Fresh Boarder
  • Posts: 7
  • Thank you received: 0
Daniel, you were right about the yvcomment :blink: . I have tried the component but then uninstalled it, except the plugins, which were still activated. I didn't know they interfere with JoomlaComment.

My bad, I'm very sorry about that. All the errors were produced by the yvcomment plugins, which interpreted for example to <strong> !!! And the "cite" attribute was their fault too..

Mark this topic as closed, everything works now. It would be nice if you mentioned on the JoomlaComment's documentation about this "incompatibility", in case there are others like me.

Thanks for the help mate.

after Beta2 ::: still invalid XHTML markup 14 years 9 months ago #5972

  • JonusC
  • JonusC's Avatar
  • Offline
  • Platinum Boarder
  • Platinum Boarder
  • Posts: 785
  • Thank you received: 48
valandis wrote:

Mark this topic as closed, everything works now.

We tend to keep topics open incase another user has a similar problem and decides to reply instead of making a new thread :)

It would be nice if you mentioned on the JoomlaComment's documentation about this "incompatibility", in case there are others like me.

We could, but this kind of thing is standard for all Joomla extensions. Because Joomla Plugins are designed to modify existing components in-place as they are generated by PHP, it's impossible to predict compatibility with other issues or to even track such things. Regardless, a Disclaimer along the lines of "JoomlaComment is not supported with other Commenting systems - ensure all other Comment Plugins, Components, Modules and Extensions are disabled while you use JoomlaComment" is indeed a good idea.
  • Page:
  • 1
Time to create page: 0.133 seconds