TOPIC: Problems with some emoticons

Hi guys,

I'm new to !joomlacomment, so forgive me if my question had already been answered, though I searched the forum and couldn't find the solution. That could also mean I'm doing something else wrong

Anyway, the thing is this: when trying to publish some emoticons I get a code combined with some other emoticons, they are interrupting it the same way that happens with ie. MSN when you type a word that contains the shortcut to an emoticon.

Apart from being new to this component, I'm really new to Joomla and programming as well, so this might be due to something I did wrong elsewhere. I'm still trying to figure out how to move to php5, so for the time being I changed the code to fit with my php4.3.11 as was explained in one of your articles. My MySQL is 5.0.18 so that should be fine.

Here's a link with some test comments, so you guys can see what I'm talking about.

Also, where would be the right place to post an updated version of the serbian_lat translation, since the current one is rather messy and not written in UTF-8?

Thanks a lot, this is by far the best comment component I found!

All best,
M.

EDIT: The problem is in emoticon: every other that starts with S (side, silly) will be published, but followed by its unnecessary duplicated code, interrupted with emoticons. I guess the simple solution would be to change the code of this one, but then again if I'm the only one having this problem it must be something else.

Hey there!
DId you make any changes to the code?
When looking at the ouput I see this:and the normal output is:

Wow, haven't touched it, how could this happen? I believe I should try and change all codes to fit the one you presented? This is really weird, I downloaded the component from this site two days ago or so...But thanks a lot for the quick reply and help!

Btw, you haven't told me - where can I upload the corrected translation to Serbian? It's not a big deal, but I guess it'd be useful... Cheers!

Upload it here in the forum.

I actually don't know where to find the file that contains the code you're talking about...
When I change from 'funny' to some other type of emoticons, the problem disappears, still I'd like to use this specific set...

aha. Would you go to components/com_comment/joscomment/emoticon/modern and tell me what do you have in the php file there?

A list of lines that look like this one:

This index.php doesn't containemoticon, while index.php in 'funny' does.

well different icon packs have different icons and different syntax. That is why you don't have .
I don't know what the problem could be. Perhaps you can try to copy the code from the index.php file of the modern icons to the one of the other and see if you have problems? It is obvious that some emoticons are not going to load, since there is no emoticon for them, but just for the test...

Cool, will do that. If nothing, I'm fine with just outcommenting the or changing its shortcut. I thought maybe some other folks out there might have the same problem so if it was a small bug it'd be cool. Obviously it's something mystical so we better leave it this way
Thanks a lot for the feedback!

PS: I uploaded the translation in another thread, in case it's useful for some further upgrades. Cheers!

I managed to solve the problem by just changing the following line:

to

Capitalization, that was all. Duh!

You could also try changing the emoticons from......to......which enforces a 'padding' on the emoticon trigger. Many instant messenger programs, especially the fantastic Trillian which I use for MSN, have an option for this kind of thing. It prevents :sillyperson from drawing a emoticon that way as it requires a whitepsace on either side, stopping mid-word emoticon catching.

I noticed another user had the same problem with emoticons. I don't understand why this happens. Do we need to fix a bug Daniel? I have no idea what is causing such a strange behaviour!

Matija wrote:

I managed to solve the problem by just changing the following line:

$GLOBALS["JOSC_emoticon"][':s'] = "dizzy.png";

to

$GLOBALS["JOSC_emoticon"][':S'] = "dizzy.png";

Capitalization, that was all. Duh!

I had the same problem.. But i´m using the Funny set of emoticons...

The problem was that when the user inserted the "" (silly) it showed messy code and another emoticon, the "" (s)

I guess this happens because they are similar to one another in the begining...

I think this needs a bug fix for next versions.... And I think this would happen to anyone using 4beta1 and some of the emoticons set... Its just that people maybe do not notice this...

The solution provided above from Matija solved the problem...

It's a workable solution but not exactly solid... what if they do any of these emoticons:The new code is case sensitive so it'd only work for those who physically click on the icons. But I, like many of the Instant Messenger generation, type in frequently - sometimes with a big S, sometimes with a small S.

I think it'd be best to change the code of emoticon replacement to be case insensitive, and instead zero-pad the definitions as I did. That would also prevent the following sentance...From showing "Step 2 elect the..." as it doesn't have a whitespace on both sides of the emoticon. If you didn't notice, these Forums do a similar thing - they put a space on either side

I don't mean to shoot you guys down at all the caps substitute is a good quick fix. I'm mostly saying all that for Daniel to review, ultimately the decision is up to him

agreed....

the solution was a "quick fix" for a "small problem"...

As for now, its okay, but i think you are correctly... Suggest these modifications to daniel.. So next releases wont have this issue..

And thanks for the support.

Daniel, just FYI - This has not been fixed in the new version.

I think it was a mistake in the emoticon design to have then another :something: - we could change to =s for example but that'd break all existing comment emoticons.

I tried re-writing the parseEmoticons() function to check for whole-word matches, but it's beyond me. If that's something Daniel wants to do then that's great.

However I think it's easier to add a whitespace to the emoticon theme php file for each one. It works fine, although "." will not work as it needs whitespace after " " to replace the graphic. However, if the user clicks an emoticon it will insert it in the comment correctly.

It's up to Daniel which he wishes to do for a fix in the next release. Chances are I/we will soon make a new default emoticon set with different, non-conflicting tags anyway.

I'm going to rewrite the function, but right now all my attention is concentrated on BiggieSmalls

I'm really pissed from all these template clubs sites, that only take your money and don't give you anything in return and they deserve to be punished