×

Notice

The forum is in read only mode.
Welcome, Guest
Username: Password: Remember me
  • Page:
  • 1

TOPIC: Invalid XHTML Markup

Invalid XHTML Markup 15 years 5 months ago #4500

  • valandis
  • valandis's Avatar Topic Author
  • Offline
  • Fresh Boarder
  • Fresh Boarder
  • Posts: 7
  • Thank you received: 0
First of all I wanna thank you for this great Joomla component. Many advantages of your commenting system indeed, Ajax refreshless really rocks and saves too much bandwidth.

Everything was ok with the component except one thing, it doesn't produce valid XHTML Markup. I installed and tried both versions, 3.26 and 4.0 alpha, just to double check the problem. The older version 3 produces more errors in the Markup than the newer version for sure, but.. there are still Markup errors.

The errors I have found are located within the component's template files and more specifically:
  • JQdefault-emotop: 1 error
  • MTdefault-emotop: 1 error
  • SSlide-emotop: 1 error
  • SSlideBoth-emotop: 2 errors
The problem is that you use in the internal script of JavaScript the character "<". One work-around would be to put the whole JavaScript code, which needs this character "<" in an external script and call it from the template; this what W3C suggests in such situations.

I hope you gonna fix this soon mate, because those sliding effects are pretty cool, especially if they could produce valid XHTML.

Keep up the good work!

Invalid XHTML Markup 15 years 5 months ago #4558

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
Hey there!
Those templates need to be rewritten. After that we will have valid xhtml. For the moment the only template with valid markup is the modern one.

Invalid XHTML Markup 15 years 5 months ago #4561

  • valandis
  • valandis's Avatar Topic Author
  • Offline
  • Fresh Boarder
  • Fresh Boarder
  • Posts: 7
  • Thank you received: 0
Thanks for the reply mate, actually I'm using the 4.0 alpha version with the "default-emotop" template now, which is also XHTML valid (as well as the default and modern one). But the sliding effects are really cool if you could implement them with valid Markup.

I hope the new version gonna come out soon, because this is really one of the best free commenting systems on Joomla!

Invalid XHTML Markup 15 years 5 months ago #4562

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
Well, in beta1 there are no improvements to these templates. I will start working on them after beta1 is released.

And why are you so in rush for the XHTML versions of the templates?

Invalid XHTML Markup 15 years 5 months ago #4563

  • valandis
  • valandis's Avatar Topic Author
  • Offline
  • Fresh Boarder
  • Fresh Boarder
  • Posts: 7
  • Thank you received: 0
Because for me it's important to have valid Markup and CSS too. My Site's validated and I want to keep it that way, as well as new Sites I make
..and because the templates with the sliding effects are really nice :)

For your info, I tried to fix the problem by hacking into one of the templates (the SSlideBoth-emotop) and putting the problematic piece of code in an external JavaScript; after that the pages were validated, except the initial state of the form plus and/or comments was always "visible". The script is inside the index file of the template and located in lines 292-323.
  • Page:
  • 1
Time to create page: 0.112 seconds