×

Notice

The forum is in read only mode.
Welcome, Guest
Username: Password: Remember me
  • Page:
  • 1

TOPIC: Quote does not nest

Quote does not nest 12 years 9 months ago #15280

  • Adrian Cooper
  • Adrian Cooper's Avatar Topic Author
  • Offline
  • Junior Boarder
  • Junior Boarder
  • Posts: 30
  • Karma: 1
  • Thank you received: 0
I have noticed that a reply to an existing comment will properly nest the reply under the original comment in context.

However, if I click "Quote" against the same comment, it is not nested but posted as a new comment.

"Quote" should of coutrse be nested, because it is still a reply to an existing comment but quoting that comment.

Have I overlooked a setting here, or is this a bug?

If quotes do not nest under the comment bening quoted, then I will need to remove the Quote button to avoid confusion.

Thanks.

Re: Quote does not nest 12 years 9 months ago #15284

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
I'm not sure that I understand what you mean?

Why should a quote automatically trigger nesting? Only a reply to a specific comment triggers nesting. I'm quoting you, I'm not replying to your comment. That are 2 different tasks.

I can quote more than one person - so where do we nest the comment in that case?

Regards,
Daniel

Re: Quote does not nest 12 years 9 months ago #15285

  • Adrian Cooper
  • Adrian Cooper's Avatar Topic Author
  • Offline
  • Junior Boarder
  • Junior Boarder
  • Posts: 30
  • Karma: 1
  • Thank you received: 0

Daniel Dimitrov wrote: I'm not sure that I understand what you mean?

Why should a quote automatically trigger nesting? Only a reply to a specific comment triggers nesting. I'm quoting you, I'm not replying to your comment. That are 2 different tasks.

I can quote more than one person - so where do we nest the comment in that case?

Regards,
Daniel


Well to me there is absolutely no difference between Replying to an existing Comment and Quoting an existing Comment, except that in the case of Qutoting, some or all of the original text is being included in the Reply.

To Quote an existing comment out of context with the comment being quoted on is definitely an anomaly.

But this is only my view.

For now I would be more than happy to remove the "Quote" button completely.

Re: Quote does not nest 12 years 9 months ago #15289

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
Unfortunatly you can not do a template override right now and you will have to directly edit the JOSC_post.php class.

go to
components/com_comment/classes/joomlacomment/josc_posts.php
line 554:
		if ($this->_support_UBBcode) {
			$edit .= $this->linkQuote($id);
		}

you can remove it all together or just comment it out.

I would like to see what other people about this, but I think that quote and reply are 2 different actions and they should stay this way.

Cheers,
Daniel

Re: Quote does not nest 12 years 9 months ago #15291

  • Adrian Cooper
  • Adrian Cooper's Avatar Topic Author
  • Offline
  • Junior Boarder
  • Junior Boarder
  • Posts: 30
  • Karma: 1
  • Thank you received: 0

Daniel Dimitrov wrote: Unfortunatly you can not do a template override right now and you will have to directly edit the JOSC_post.php class.

go to
components/com_comment/classes/joomlacomment/josc_posts.php
line 554:

		if ($this->_support_UBBcode) {
			$edit .= $this->linkQuote($id);
		}

you can remove it all together or just comment it out.

I would like to see what other people about this, but I think that quote and reply are 2 different actions and they should stay this way.

Cheers,
Daniel


Thanks Daniel.

I always comment code out - never actually delete it, and only after backing up the file first.

I agree this is a matter of opinion, but when I tested my site and say that quotes text was not in the context of the comment being quoted, it was very obvious to me :)

I would like to hear what others think as well.

Again though - and I know I keep saying this - CompoJoom Comments is a truly exceptional Component which I am very happy to have purchased - I just need to make it work they way it want it to work :) It is very close.

Re: Quote does not nest 12 years 9 months ago #15296

  • Adrian Cooper
  • Adrian Cooper's Avatar Topic Author
  • Offline
  • Junior Boarder
  • Junior Boarder
  • Posts: 30
  • Karma: 1
  • Thank you received: 0

go to
components/com_comment/classes/joomlacomment/josc_posts.php
line 554:

		if ($this->_support_UBBcode) {
			$edit .= $this->linkQuote($id);
		}


When I commented out this code it caused my site to white screen.

I un-commented it and tried different combinations, but still a white screen.

All I really need to do is comment out the display for the "Quote" text - not the entire Quote function.

Re: Quote does not nest 12 years 9 months ago #15299

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
White screen means that you've caused a fatal error. If you enable the php error output, then you should see what exactly has happened.

commenting out or deleting those 3 lines should not cause a fatal error.

Daniel

Re: Quote does not nest 12 years 9 months ago #15300

  • Adrian Cooper
  • Adrian Cooper's Avatar Topic Author
  • Offline
  • Junior Boarder
  • Junior Boarder
  • Posts: 30
  • Karma: 1
  • Thank you received: 0

Daniel Dimitrov wrote: White screen means that you've caused a fatal error. If you enable the php error output, then you should see what exactly has happened.

commenting out or deleting those 3 lines should not cause a fatal error.

Daniel


Thanks Daniel - I have fixed it now - works perfectly :)

Thanks for your help as always.

Re: Quote does not nest 12 years 7 months ago #15755

  • Martin Roeder
  • Martin Roeder's Avatar
  • Offline
  • Senior Boarder
  • Senior Boarder
  • Posts: 46
  • Thank you received: 0
Well, my few cents here because i also thought about this months ago.

I understand both points but from my long commenting experience and using tools like IntenseDebate or Disqus i noticed that the person who quotes someone else does want to stay to 95% inside the related discussion.
Sure there are some people from time to time who quote several comments at once but in this case they use mostly the quote tag instead of using the quote button.

On the other hand i understand totally what Daniel says:

I'm quoting you, I'm not replying to your comment. That are 2 different tasks.

I have on my old site more than 5600 comments and some of my members asked me the same.
I gave them mostly the same answer like Daniel above and told them to "reply" and then to use the "quote" tag if they want to stay inside the actual discussion.

Sometimes i was really happy that some people quoted and that a new un-nested discussion started because the comments were nested, nested, nested and nested and after 120 replies we all had only a small frame to reply :silly: (which is normal).

All in all i would do it like this way:
Add 2 buttons:
- Quote as Reply
- Quote as New

This would solve it and all would be happy.
Only my few cents and a suggestion. :)

greets!
Marin

Re: Quote does not nest 12 years 7 months ago #15770

  • Adrian Cooper
  • Adrian Cooper's Avatar Topic Author
  • Offline
  • Junior Boarder
  • Junior Boarder
  • Posts: 30
  • Karma: 1
  • Thank you received: 0

Martin Roeder wrote: Well, my few cents here because i also thought about this months ago.

I understand both points but from my long commenting experience and using tools like IntenseDebate or Disqus i noticed that the person who quotes someone else does want to stay to 95% inside the related discussion.
Sure there are some people from time to time who quote several comments at once but in this case they use mostly the quote tag instead of using the quote button.

On the other hand i understand totally what Daniel says:

I'm quoting you, I'm not replying to your comment. That are 2 different tasks.

I have on my old site more than 5600 comments and some of my members asked me the same.
I gave them mostly the same answer like Daniel above and told them to "reply" and then to use the "quote" tag if they want to stay inside the actual discussion.

Sometimes i was really happy that some people quoted and that a new un-nested discussion started because the comments were nested, nested, nested and nested and after 120 replies we all had only a small frame to reply :silly: (which is normal).

All in all i would do it like this way:
Add 2 buttons:
- Quote as Reply
- Quote as New

This would solve it and all would be happy.
Only my few cents and a suggestion. :)

greets!
Marin


Excellent and balanced post Marin.

In summary, there is no "right" or "wrong" way about this - it is entirely a matter of perspective.

For me, the only difference between "Quote" and "Reply" is that "Quote" includes the text of the post being "replied to".

I have removed the "Quote" link altogether so that users either submit a new "Post" or "Reply" below to an existing post.

This is a good solution for me because I find that users tend to over-use the "Quote" button resulting in numerous nested, identical quotes.

That said, I really like your suggested solution because it covers all eventualities.

I hope Daniel considers this for a future version, but for now, I am happy with my compromise of removing "Quote" altogether.

Re: Quote does not nest 12 years 7 months ago #15772

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
Hey Guys!
Yes Martin, this seems like a good proposal and I'm willing to add it. This actually should be extremely easy to do once I have completely refactored the extension. (and it can work on a template level...) In the next weeks we should see the first beta of the new version...

Let us look again at this problem once we have the new version there. Thank you for understanding!

Daniel
  • Page:
  • 1
Time to create page: 0.123 seconds