×

Notice

The forum is in read only mode.
Welcome, Guest
Username: Password: Remember me
  • Page:
  • 1

TOPIC: Nice Matrix Banner

Nice Matrix Banner 6 years 1 month ago #29177

  • Josh Lewis
  • Josh Lewis's Avatar Topic Author
  • Offline
  • Expert Boarder
  • Expert Boarder
  • Posts: 89
  • Thank you received: 3
Just wanted to compliment your neat Matrix banner. It even mentions my name. :cheer:

Nice Matrix Banner 6 years 1 month ago #29180

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
Glad you like it Josh! Btw, I've refactored the code for the custom fields and now it is part of our library. I'll have to clean few things up and I'll add it into ccomment :)

Cheers,
Daniel
The following user(s) said Thank You: Josh Lewis

Nice Matrix Banner 6 years 1 month ago #29185

  • Josh Lewis
  • Josh Lewis's Avatar Topic Author
  • Offline
  • Expert Boarder
  • Expert Boarder
  • Posts: 89
  • Thank you received: 3
It will literally be the coolest thing of the week when it comes out! :cheer: Custom fields means a lot to me. B) Thanks for working on this, as always we appreciate what you do Daniel. Many possibilities will open up with this.

Nice Matrix Banner 6 years 1 month ago #29422

  • Josh Lewis
  • Josh Lewis's Avatar Topic Author
  • Offline
  • Expert Boarder
  • Expert Boarder
  • Posts: 89
  • Thank you received: 3
I forgot to mention, if you need a beta tester for it you know who to call. B) Hope all is well with the Compojoom staff. :)

Nice Matrix Banner 6 years 1 month ago #29447

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
Hey Josh,
So my christmas present for you is ready :)
Just pushed a new dev. release for ccomment, that supports custom fields. (you'll find it in the dev. section)
In the backend under ccomment -> custom fields you can configure the custom fields. They can be configured both for all components or just for specific components.
In the frontend then when you click on the form, the custom fields should show. The values that the user entered in the custom field will show below their comment. The one thing that I'm not sure about is the design. Not really happy with the way they look right now. If you have ideas how to style them let me know!
Regards,
Daniel
The following user(s) said Thank You: Josh Lewis

Nice Matrix Banner 6 years 3 weeks ago #29527

  • Josh Lewis
  • Josh Lewis's Avatar Topic Author
  • Offline
  • Expert Boarder
  • Expert Boarder
  • Posts: 89
  • Thank you received: 3
This is really exciting! :cheer: Pardon the delay, had to renew my subscription and had some holiday distractions.

A few things I should highlight:

1. When saving a custom field without a title, it does not save and dumps all the data. I understand that a title is a required field, so what I'm suggesting is for the validator in the backend to check this before attempting to save. This will prevent users from doing a bunch of work only to have it removed. After putting in a title, saving worked of course but had to re-fill out the data. :P

2. Near the bottom of custom field options it says "When it's not checked the field validation is enabled and the user will not be able to submit a hotspot unless he fills this field."

It should say "comment" instead of "hotspot". Also I suggest changing the "he" to "he/she", but that's up to you. ;)

3. Will checkboxes be added? They are mentioned in text twice, but there is no field type for them.

4. Not sure we need to have it say "Custom fields" after posting the comment. The viewer should be able to figure out what the data means based on how the administrator constructs it. The reason I'm proposing the removal of the text is because it's a little more clutter to the nicely fashioned Ccomment form. B)

5. When viewing the list of custom fields in the backend, the titles should link to the edit page of the custom form. I know you can edit the custom field by clicking the checkbox and then clicking the edit button, but this isn't as friendly. Joomla articles in the backend for example allow you to click the title to edit the article.

I should send you an email soon regarding styling the custom forms. Overall I'm really excited about the direction of CComments.

Nice Matrix Banner 6 years 3 weeks ago #29528

  • Josh Lewis
  • Josh Lewis's Avatar Topic Author
  • Offline
  • Expert Boarder
  • Expert Boarder
  • Posts: 89
  • Thank you received: 3
Also forgot to mention the smilies button broke in the dev version. In other words the smilies do not come out when clicking the smiley button from the editor.

Nice Matrix Banner 6 years 3 weeks ago #29586

  • Josh Lewis
  • Josh Lewis's Avatar Topic Author
  • Offline
  • Expert Boarder
  • Expert Boarder
  • Posts: 89
  • Thank you received: 3
I discovered a few more issues with custom fields:

- When I add a title field along side with another field, the entire custom fields display twice on the article.

- In the backend of Custom fields there is an option called "When to show", if I say "Specific Components" and have it set to "com_content", the custom field does not display at all.

- After publishing a comment that has the custom field "title", when I edit the comment the data filled in disappears.

I also suggest have a display label option for each custom field. For many of us it doesn't make much sense to say "Title: This is a great article". ;) I understand the top label "Custom Fields". There should be a yes/no option to enable/disable the label for that custom field.

Nice Matrix Banner 6 years 2 weeks ago #29591

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
Okay fixed all things from your first post.
I added a checkbox type, but don't plan to add checkboxes.

About your second post.
- I don't understand what you mean with the title field???
- if the custom field is set to com_content it should show in com_content entries. Are you sure that you are commenting in com_content?
- yes, edit is not implemented yet

I would hide the label with a template override and not with an option. But will think about this a little more.

Regards,
Daniel

Nice Matrix Banner 6 years 2 weeks ago #29592

  • Josh Lewis
  • Josh Lewis's Avatar Topic Author
  • Offline
  • Expert Boarder
  • Expert Boarder
  • Posts: 89
  • Thank you received: 3
I personally only need a single checkbox which you happened to have made. :) But I am curious about why you decided not to allow many? Too many fields per record?

The title issue might not be purely the title field causing this (other fields might be affecting this). I'll get back to figuring out this mystery once editing comments is fixed unless I manage to figure it out before then. I want to prove my issues so that you know exactly what I'm talking about. ;)

I'm noticing some strange behavior in a few cases (these issues have existed since the beginning of custom fields if I recall right). The comments keep attempting to load here (with no success):
www.test.alpineascent.com/mountain/176-e...ccomment-content-176

Also data seems to be repeating itself based on the number of custom fields as seen here:
www.test.alpineascent.com/mountain/175-t...ccomment-content-175

My most recent support ticket mentioned why the EasySocial avatars are not loading. If you're still unsure by why this is happening I can provide some easy evidence that will put it all in good light. B) Anyways, once again your work for Ccomments goes greatly appreciated!

Nice Matrix Banner 6 years 2 weeks ago #29605

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
Ahahaa! Comments are not loading because I have a bug in the query to load the avatars. It's working in my case, because I have only 1 user -> me. But in your case you try to load the avatars of 2 users and the query fails :)

That thing with the repeating custom fields is funny. I'll have to look into it. Most probably I've done something wrong.
I'll let you know once I've fixed those issues.
The following user(s) said Thank You: Josh Lewis

Nice Matrix Banner 6 years 2 weeks ago #29607

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
Okay, the issue with loading comments should be fixed now.
Also custom fields will be rendered just once.

The problem with the path to easyblog's avatar is still there. Don't know which easyblog function to use to get the path. Waiting for feedback from Mark.

Cheers,
Daniel

Nice Matrix Banner 6 years 2 weeks ago #29609

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
Just pushed a release that is able to edit the custom fields as well.
The following user(s) said Thank You: Josh Lewis

Nice Matrix Banner 6 years 2 weeks ago #29619

  • Josh Lewis
  • Josh Lewis's Avatar Topic Author
  • Offline
  • Expert Boarder
  • Expert Boarder
  • Posts: 89
  • Thank you received: 3
Yeay, three issues fixed with the new update. :cheer: It's becoming more stable. B)

Daniel Dimitrov wrote: The problem with the path to easyblog's avatar is still there. Don't know which easyblog function to use to get the path. Waiting for feedback from Mark.


You mean EasySocial. EB is cool too. ;) It's the weekend, so hopefully we hear something on Monday or Tuesday. Thanks for sending out a request to Mark.

As for the checkbox, right now it outputs "Checkbox 1" instead of a actual checkbox. I'm trying to get my comment custom fields to look like this: www.summitpost.org/sherman-peak/climbers-log/780602 (notice the actual checkbox?)
Styling wise I know how to make it look right. Once again I appreciate the fixes. :)

Nice Matrix Banner 6 years 2 weeks ago #29621

  • Josh Lewis
  • Josh Lewis's Avatar Topic Author
  • Offline
  • Expert Boarder
  • Expert Boarder
  • Posts: 89
  • Thank you received: 3
I looked into the checkbox deal a little more. The site mentioned above uses an image to display the checked checkbox. So perhaps instead of showing the number 1, it could show a font icon instead? Or at the very least assign a class to the dd tag that uses the class "icon-checkbox". Joomla 3 has a standard list of classes for the font icons as seen here .

A minor issue is that custom fields show up regardless to whether or not I fill them out. So for example if I don't fill out any custom fields at all, the text "Custom Fields" still displays below the comment along side with the field title. It doesn't make sense to the viewer to display this when there is no actual data for the custom fields being filled out. ;) I keep that information optional for my users.

I re-read this entire thread looking over all the issues. The title issue you were confused about is now resolved. The specific component issue was actually my fault. I didn't realize it was a select list (I thought it was a text one) which is why I did not select com_content. That part works as expected too.

Nice Matrix Banner 6 years 2 weeks ago #29626

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
I've written some docs that I haven't published yet.

<?xml version="1.0"?>
<ns:clipboard
xmlns:ns=" www.xmlmind.com/xmleditor/namespace/clipboard "
><para
><emphasis
role="bold"
>Checkbox</emphasis
>. You can enter the following options:</para
><programlisting
>checked=true
translate=true</programlisting
><para
>The <option
>checked</option
> parameter can be either <option
>true</option
> or <option
>false</option
>. This would define if the field is selected per default or not. The <option
>translate</option
> variable can be either <option
>true</option
> or <option
>false</option
>. This would define whether the selected value would be shown translated in the frontend (once the user has submitted the form). For example if you enter lorem as default value for the field and the translate option is set to true, then you can specify the following language variable:</para
><programlisting
>COM_COMMENT_CUSTOMFIELDS_CHECKBOX_VALUE_REPLACESLUG_REPLACEVALUE="My translated value"</programlisting
></ns:clipboard
>


So basically if you add translate=true -> you'll be able to translate the value. Now with your above example I realize that a better option would be to have a
value_checked=whatever -> even image or div, whatever you want as htmu
value_unchecked=whatever

This would be better I think. Then you could decide how you want it styled for each checkbox.

Also in the latest dev. release -> the custom fields should not show when they are not filled out.

What do you think about the checkbox?

Regards,
Daniel
The following user(s) said Thank You: Josh Lewis

Nice Matrix Banner 6 years 2 weeks ago #29630

  • Josh Lewis
  • Josh Lewis's Avatar Topic Author
  • Offline
  • Expert Boarder
  • Expert Boarder
  • Posts: 89
  • Thank you received: 3
The "value_checked=" and "value_unchecked=" is a great idea! :cheer: Be sure not to require "value_unchecked=" so that if we wanted it blank, we could display nothing if desired. I see this possibly being problematic when assigning classes which would look like "value_checked=<i class="icon-checkbox"></i>". The issue due to the double equal sign. I suppose I could just pick unique HTML elements and then work off of the ccomment class above it. Also I'm curious if this data would be filled into the Options field?

I have a question regarding field types. With the field type "Select List" how does one create a null value? So for example if I post a comment I want by default for nothing to be filled out. Another scenario is if the user chooses to change their mind and want nothing to display in the select list field type. I could probably put up a blank value, but I want that custom field hidden if the user did not fill anything out in the select list. The other fields allow this, select list should too.

I suggest adding a custom fields link in the administrator sub menu as seen in this screen shot:

Attachments:

Nice Matrix Banner 6 years 2 weeks ago #29631

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
For the select list you just need space equals Select a value like this
 =Select a value

there is an empty space before the equal sign (=).

I also made the changes to the checkbox field. Check the docs: compojoom.com/support/documentation/ccomment/ch04
Let me know if you find something.

Regards,
Daniel
The following user(s) said Thank You: Josh Lewis

Nice Matrix Banner 6 years 2 weeks ago #29632

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
Ah forgot to say - 5.3 is out :)
The following user(s) said Thank You: Josh Lewis

Nice Matrix Banner 6 years 2 weeks ago #29642

  • Josh Lewis
  • Josh Lewis's Avatar Topic Author
  • Offline
  • Expert Boarder
  • Expert Boarder
  • Posts: 89
  • Thank you received: 3
Awesome, Ccomments 5.3 is working really good. B) I hope I'm not asking for too much, but a date field would also be a really cool field type. Basically I am using Ccomments as a logging system for places people travel to. Allowing people to be able to say when an event took place would help people better know when the best time to go to that place is as well as reminding the signer when the event took place.

Here is a screen shot to give you some inspiration:



For my case I only need the date, but understand if you want to include the time too. An end date isn't required for my project but would be a neat addition. A date field will keep me happy for a while! :cheer: The screen shot above used EasySocial to get the date picker. A basic date custom field would also work too depending on your flavor of interest.
Attachments:
  • Page:
  • 1
Time to create page: 0.281 seconds