×

Notice

The forum is in read only mode.
Welcome, Guest
Username: Password: Remember me
  • Page:
  • 1

TOPIC: JED editors claim errors using JEDchecker

JED editors claim errors using JEDchecker 4 years 4 months ago #21418

  • Joachim Schmidt
  • Joachim Schmidt's Avatar Topic Author
  • Offline
  • Fresh Boarder
  • Fresh Boarder
  • Posts: 6
  • Thank you received: 0
hi,

I wanted to share my extension to the JED - now the JED editors put following into error box and claim this to be errors:
PH1-PHP Headers missing GPL License Notice
 
Error Comments from the Team
Rule PH1 - PHP Headers missing GPL License Notice
5 Info
#001 /plg_jmootips-v1.0.0/install_jmootips.php in line: 5
 
GPL license was found: * @license http://www.gnu.org/licenses/gpl-2.0.html GNU/GPL
#002 /plg_jmootips-v1.0.0/jmootips.php in line: 5
 
GPL license was found: * @license http://www.gnu.org/licenses/gpl-2.0.html GNU/GPL
#003 /plg_jmootips-v1.0.0/jmootips_ajax.php in line: 5
 
GPL license was found: * @license http://www.gnu.org/licenses/gpl-2.0.html GNU/GPL
#004 /plg_tipbutton-v1.0.0/install_tipbutton.php in line: 5
 
GPL license was found: * @license http://www.gnu.org/licenses/gpl-2.0.html GNU/GPL
#005 /plg_tipbutton-v1.0.0/tipbutton.php in line: 5
 
GPL license was found: * @license http://www.gnu.org/licenses/gpl-2.0.html GNU/GPL

can you comment on this?
Thank you sofar!

JED editors claim errors using JEDchecker 4 years 4 months ago #21420

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 154
  • Thank you received: 1081
Well, the info is self explaining -> you are missing a GPL license comment in your install_jmootips.php file. Open it, add the license info, save it, update your package and resubmit to the JED.

Regards,
Daniel

JED editors claim errors using JEDchecker 4 years 4 months ago #21423

  • Joachim Schmidt
  • Joachim Schmidt's Avatar Topic Author
  • Offline
  • Fresh Boarder
  • Fresh Boarder
  • Posts: 6
  • Thank you received: 0
hi,

I had a license in the header of "install_jmootips.php". I've checked this on my site with JEDchecker and I got expected results:
#001 C:\myjoomla25\tmp\jed_checker\unzipped\jmootips_package-v1.0.0.zip\plg_jmootips-v1.0.0\install_jmootips.php in line: 8
GPL license was found: # @license http://www.gnu.org/licenses/gpl-2.0.html GNU/GPL
 
#002 C:\myjoomla25\tmp\jed_checker\unzipped\jmootips_package-v1.0.0.zip\plg_jmootips-v1.0.0\jmootips.php in line: 5
....
....
Could it be that the JED editor missed it by doing copy and paste?
At least I've resubmitted my zip-file - waiting what happens...

Thanks a lot!!!

JED editors claim errors using JEDchecker 4 years 4 months ago #21424

  • Joachim Schmidt
  • Joachim Schmidt's Avatar Topic Author
  • Offline
  • Fresh Boarder
  • Fresh Boarder
  • Posts: 6
  • Thank you received: 0
hi,

As I was bit confused about your comment, I've checked my first post again and counted the messages:
- I've 5 php-scripts in my extension, which have to be checked by JEDchecker
- and I got 5 messages"GPL license was found: # @license www.gnu.org/licenses/gpl-2.0.html GNU/GPL"

so I think the JED editor just did wrong (as you did), because the line-layout of JEDchecker lead him to wrong asignments of code to license.

Can you change this in you coding?
Thanks a lot,
Joachim

JED editors claim errors using JEDchecker 4 years 4 months ago #21425

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 154
  • Thank you received: 1081
can I see your module?

JED editors claim errors using JEDchecker 4 years 4 months ago #21426

  • Joachim Schmidt
  • Joachim Schmidt's Avatar Topic Author
  • Offline
  • Fresh Boarder
  • Fresh Boarder
  • Posts: 6
  • Thank you received: 0
hi,

I've attached it (it is two plugins)...
Attachments:

JED editors claim errors using JEDchecker 4 years 4 months ago #21427

  • Joachim Schmidt
  • Joachim Schmidt's Avatar Topic Author
  • Offline
  • Fresh Boarder
  • Fresh Boarder
  • Posts: 6
  • Thank you received: 0
hi,

I did another run with a missing licence. With this JEDchecker did show me an error message (not Info) that there was a missing license.

Strange, that the JED-editors do not know this.

JED editors claim errors using JEDchecker 2 years 8 months ago #29932

  • php vish
  • php vish's Avatar
  • Offline
  • Fresh Boarder
  • Fresh Boarder
  • Posts: 1
  • Thank you received: 0
when i uploaded a template in jed checker the following error occur...You've used encoding in this file? This is not an error, but an editor will have to review this file! ...i unable to find why this error occurs.

JED editors claim errors using JEDchecker 2 years 8 months ago #29934

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 154
  • Thank you received: 1081
As the message says - this is not an error...
You've used a base64 function. Depending on what you are doing with this function the editors in the JED will decide if they'll approve your extension or not.

But you are saying that you are testing with a template??? The JED is only for extensions, so I don't understand what's the point?
  • Page:
  • 1
Time to create page: 0.116 seconds