×

Notice

The forum is in read only mode.
Welcome, Guest
Username: Password: Remember me
  • Page:
  • 1

TOPIC: Strict notice in J! 3.4

Strict notice in J! 3.4 2 years 7 months ago #30471

  • Hugh Messenger
  • Hugh Messenger's Avatar Topic Author
  • Offline
  • Fresh Boarder
  • Fresh Boarder
  • Posts: 9
  • Thank you received: 2
Hey Daniel,

I'm sure you are probably aware, but just tiny issue after the J! 3.4 update ...

Strict standards: Declaration of JMail::addAttachment() should be compatible with PHPMailer::addAttachment($path, $name = '', $encoding = 'base64', $type = '', $disposition = 'attachment') in /var/www/html/jomsoc/plugins/system/mandrill/mailer/mail.php on line 43

Sent you a PR ...

github.com/compojoom/cmandrill/pull/1

-- hugh

Strict notice in J! 3.4 2 years 7 months ago #30710

  • Richard Gracile
  • Richard Gracile's Avatar
  • Offline
  • Fresh Boarder
  • Fresh Boarder
  • Posts: 1
  • Thank you received: 0
Hi there. Love your extension. But we are having the same problem since updating to 3.4. I've attached a screenshot.
Additionally, it is now affecting the site Frontend. So we can't keep the plugin portion switched on and have the site display correctly.
Anything you can do?
Thanks!
Rich
Attachments:

Strict notice in J! 3.4 2 years 7 months ago #30716

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 154
  • Thank you received: 1081
Hey Richard, Hey Hugh,

@Hugh - thanks for the PR.

We'll be working on CMandrill in April, if everything goes according to the plan. We plan to implement the complete api (as it now supports bcc, more e-mail attachments and few other goodies) and we'll have a new stats view.
For now just set error reporting on your site to none, or add Hugh changes to the code.

Regards,
Daniel

Strict notice in J! 3.4 2 years 7 months ago #30721

  • Hugh Messenger
  • Hugh Messenger's Avatar Topic Author
  • Offline
  • Fresh Boarder
  • Fresh Boarder
  • Posts: 9
  • Thank you received: 2
Richard,

You really should turn error reporting off on live production sites, only enable it on development sites or when actually trying to debug something. Enabling it not only causes "cosmetic" issues, it can break things in unpredictable ways (like causing Javascript errors when error reporting messes up JSON responses in AJAX calls), and it can expose information you don't want people knowing about your site (file paths, dataset naming, etc).

You can safely ignore this specific notice, it doesn't impact the functionality of CMandril at all. If it bugs you, just edit the file as per the PR referenced in my post, or download the fixed file from my fork on github

Hugh
  • Page:
  • 1
Time to create page: 0.077 seconds