×

Notice

The forum is in read only mode.
Welcome, Guest
Username: Password: Remember me
  • Page:
  • 1

TOPIC: Everyone can mail to all who booked an event

Everyone can mail to all who booked an event 9 years 10 months ago #26803

  • Rob Swart
  • Rob Swart's Avatar Topic Author
  • Offline
  • Senior Boarder
  • Senior Boarder
  • Posts: 57
  • Thank you received: 5
Hi Yves,

In the default event template there is a button on the bottom of the template that allows everyone to email to all who booked that event. OK, when clicking it and sending an email, there is a authorization error. But what I don't understand is why that button is there in the first place.
I don't think that this is correct. The organizer must be able to send mail to everyone that booked the event, but for that there is a button on the list of bookings of the event.
The buttons on the event template must be buttons for everyone that is viewing the event. This button is meant to ask some questions about this event to the organizer.
I also think that the buttons on top an on the bottom, must have the same functionality. You can choose if you want buttons on top, on the bottom or both. When you choose only one position, the functionality of the buttons must be the same. At least, that's my opinion.

If you agree, changing this is very easy.
Just change the 2 into 1 on this line of code:
$knopfunten .= " " . MatukioHelperUtilsEvents::getEmailWindow(MatukioHelperUtilsBasic::getComponentImagePath(), $this->event->id, 2);

Greets,
Rob

Everyone can mail to all who booked an event 9 years 10 months ago #26812

  • Yves Hoppe
  • Yves Hoppe's Avatar
  • Offline
  • Administrator
  • Administrator
  • Posts: 3519
  • Karma: 71
  • Thank you received: 556
Hi Rob,

hmm wired, normally that should have the same functionality like on the modern template (contacting the organizer). When you use an art=2 link (which only organizers / admins can) you also have a contact all participants button, maybe that's what you are seeing.

Yeah top and bottom makes some problems.. Need to rewrite the whole "old" default template some time.. sadly it's a mess.. Daniel still thinks we should remove the whole old booking form and default template, would spare us a lot of work and problems. :unsure:

Yves

Everyone can mail to all who booked an event 9 years 10 months ago #26813

  • Rob Swart
  • Rob Swart's Avatar Topic Author
  • Offline
  • Senior Boarder
  • Senior Boarder
  • Posts: 57
  • Thank you received: 5
Hi Yves,

It doesn't matter how you log in. Or even if you log in.
The parameter for this button to act as "mail to all participants" is hard coded in the template. Change that 2 into a 1 and it is solved.

As a user of your software I wouldn't be against getting rid of the old template and booking form.
But... first it must be possible to edit own bookings in the new booking form and modern template ;)

Everyone can mail to all who booked an event 9 years 10 months ago #26820

  • Yves Hoppe
  • Yves Hoppe's Avatar
  • Offline
  • Administrator
  • Administrator
  • Posts: 3519
  • Karma: 71
  • Thank you received: 556
Aye fixed that. Matukio 4.2 is coming in some minutes, allwowing to edit bookings with the new booking form and bringing a new nice booking detail site ;)

Thanks for you fedback!

Yves

Everyone can mail to all who booked an event 9 years 10 months ago #26822

  • Rob Swart
  • Rob Swart's Avatar Topic Author
  • Offline
  • Senior Boarder
  • Senior Boarder
  • Posts: 57
  • Thank you received: 5
Great!

Just installed it. Edit own booking works :)

Just a couple of small things.
The contact button on the modern event template is a link and not a button. I think the class is wrong, should be mat_button instead of btn.
There are no buttons on the new booking overview form, just links.
On the new booking overview form you can't see how many places you booked.

Everyone can mail to all who booked an event 9 years 10 months ago #26823

  • Yves Hoppe
  • Yves Hoppe's Avatar
  • Offline
  • Administrator
  • Administrator
  • Posts: 3519
  • Karma: 71
  • Thank you received: 556
Hi Rob,

just redownload the archive and install it over the Joomla Installer, had some first minute bugs in it (including that missing css for buttons and co in Joomla 2.5).

Yves

Everyone can mail to all who booked an event 9 years 10 months ago #26824

  • Rob Swart
  • Rob Swart's Avatar Topic Author
  • Offline
  • Senior Boarder
  • Senior Boarder
  • Posts: 57
  • Thank you received: 5
That's what you get when you're a early adapter :)

There's still some small things:
- Now only the Contact button is correctly formatted. The other buttons (like Ical, Invoice, Edit) are still links.
- I get a Notice when viewing the booking of an older event where certain bookingfields are missing. That's because there is no validation if the field is empty:
foreach ($fields as $field)
		{
			// Not use the Spacer fields
			if ($field->type != "spacer" && $field->type != "spacertext")
			{
				echo "<tr>";
				echo "<td class=\"key\" width=\"150px\">" . JText::_($field->label) . "</td>";
				if (!empty($value[$field->id])) {
					echo "<td>" . JText::_($value[$field->id]) . "</td>";
				}
				echo "</tr>";
			}
		}
I've added the if (!empty($value[$field->id])) code and the notice is gone.

Everyone can mail to all who booked an event 9 years 10 months ago #26825

  • Yves Hoppe
  • Yves Hoppe's Avatar
  • Offline
  • Administrator
  • Administrator
  • Posts: 3519
  • Karma: 71
  • Thank you received: 556
Hmm wired, actually we load bootstrap there so it should show up as button, like this:

demo.compojoom.com/matukio/booking?uuid=...42338a94bb13661005c1

Maybe your template has some issues with it. Do you have a link to a test booking? :)

The if (!empty($value[$field->id])) { should be arround the content (e.g. JTEXT) else you break the table layout (we always need 2 tds), fixed that for the next version.

Thanks!

Yves
The following user(s) said Thank You: Rob Swart

Everyone can mail to all who booked an event 9 years 10 months ago #26826

  • Rob Swart
  • Rob Swart's Avatar Topic Author
  • Offline
  • Senior Boarder
  • Senior Boarder
  • Posts: 57
  • Thank you received: 5
Yep, it was my template. It doesn't support bootstrap.
I've found another version of the template that does. Installed it and the buttons are nicely showing.
Thanks for pushing me in the wright direction. :)
  • Page:
  • 1
Time to create page: 0.160 seconds