×

Notice

The forum is in read only mode.
Welcome, Guest
Username: Password: Remember me
  • Page:
  • 1

TOPIC: Disable comments for the print version

Disable comments for the print version 14 years 6 months ago #9885

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar Topic Author
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
Hey Guys,
I read this review extensions.joomla.org/index.php?option=c...ewlink&link_id=12259
and I saw that the user is not happy with the fact that the comments appear in print view. I have a fix for that, that is going to go in compojoomcomment 4.1.3 . The truth is that I forgot to put this in 4.1.2. Here is my conversation with Nils about this.

23.05.2010 14:56:51 Daniel Nils Ally hey did you wanted to remove the comments from the print version?
23.05.2010 14:57:07 Nils Ally Daniel ?
23.05.2010 14:57:26 Daniel Nils Ally I know that there were users that wanted to remove the comments from the print version of their website
23.05.2010 14:57:30 Daniel Nils Ally and I know how to make it now
23.05.2010 14:58:37 Nils Ally Daniel hm... never really thought about it...
23.05.2010 14:58:58 Nils Ally Daniel sure...
23.05.2010 15:11:31 Daniel Nils Ally really easy
23.05.2010 15:11:45 Daniel Nils Ally if you go to plugins/content/joscontent.php
23.05.2010 15:11:51 Daniel Nils Ally joscomment.php
23.05.2010 15:12:08 Daniel Nils Ally on line 55 you will see if (!$published) return true;
23.05.2010 15:12:12 Daniel Nils Ally change it to this: if (!$published || JRequest::getInt('print')) return true;
23.05.2010 15:12:21 Daniel Nils Ally and now you won't see any comments in print view
23.05.2010 15:12:38 Daniel Nils Ally the same for line 62
23.05.2010 15:15:20 Nils Ally Daniel wow... that worked!

Disable comments for the print version 14 years 6 months ago #9886

  • Nils Ally
  • Nils Ally's Avatar
  • Offline
  • Gold Boarder
  • Gold Boarder
  • Posts: 299
  • Thank you received: 33
Hehe, that was actually smart, to grab the conversation like that, so people can actually see how fast it went!
I am not a programmer etc, but just getting pretty good at Ctrl + C and Ctrl + V function (cut and paste).

As you see, from the start of the conversation to the end, I had also taken a look at the Print function, just to actually see that it actually did take the comments with it firstly.
Then (of course), I had to start up my FTP, find the file, download it.
Open it in an Editor (I use Dreamweaver). Edit the two points, save it, and then upload it again.
Then refresh (F5) and test it again.

And that took (as you see) under 3 minutes!
Obviously the actual statement altering was done in seconds.
Well done Daniel!

Disable comments for the print version 14 years 5 months ago #10073

  • Joom Laner
  • Joom Laner's Avatar
  • Offline
  • Junior Boarder
  • Junior Boarder
  • Posts: 23
  • Thank you received: 0
Hi Daniel,

is there already a way in the backend to exclude the comment tool from the print version? I don' t find it in Compojoom comment 4.1.4 stable.

Best regards,
Jlaner

Disable comments for the print version 14 years 5 months ago #10076

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar Topic Author
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
Hey Joom Laner,
Yes it is possible. Just go to extensions->plugin manager->content -compojoomcomment and you will see an option for this in the settings. Cheers,
Daniel

Disable comments for the print version 14 years 5 months ago #10077

  • Joom Laner
  • Joom Laner's Avatar
  • Offline
  • Junior Boarder
  • Junior Boarder
  • Posts: 23
  • Thank you received: 0
Hi Daniel,

as much as I understand, in the settings I can enable or disable the use of the {joscommentenable} tag. So I can decide whether I want to have the comment form in all articles including the print version or to have it only in articles with the tag - also including the print version.

Is there a way in the backend to keep the comment form enabled in articles and to disable it only in the print version?

Regards,
Jlaner

Disable comments for the print version 14 years 5 months ago #10078

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar Topic Author
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
Ok, I'm looking at 4.1.4 here and the only thing that I see in the plugin settings is:
Show comments in print view: yes no

Disable comments for the print version 14 years 5 months ago #10086

  • Joom Laner
  • Joom Laner's Avatar
  • Offline
  • Junior Boarder
  • Junior Boarder
  • Posts: 23
  • Thank you received: 0
Daniel, you are completely right. May be, something went wrong with my installation process. Now I have installed 4.1.4 again, and now I see the same plugin as you describe. And it works fine!

Best regards,
Jlaner

Disable comments for the print version 14 years 5 months ago #10087

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar Topic Author
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
Hehe, that is great mate! Where is the party??? :D
  • Page:
  • 1
Time to create page: 0.102 seconds