×

Notice

The forum is in read only mode.
Welcome, Guest
Username: Password: Remember me
  • Page:
  • 1

TOPIC: Bugs Report

Bugs Report 15 years 9 months ago #2712

  • Khoa Nguyen
  • Khoa Nguyen's Avatar Topic Author
  • Offline
  • Fresh Boarder
  • Fresh Boarder
  • Posts: 5
  • Thank you received: 0
Here is the list of the bugs I found:

1. The links to the content items is not correct. It looks like the component gets the content item id from the comment id.
2. I have a little confuse about the 2 links "Content settings" and "Other Components settings", but I understand that the "Other component settings" is used for other component and it also includes the content component.
3. The MTdefault-emotop has 2 javascript errors in Firebug:
syntax error
JOSC_afterAjaxResponse("hide")
(?)()
$('JOSCMTstretchertoogleFORM').addEvent('click', function(e){\n
JOSCmySlide is not defined
JOSCmySlide.hide();

Bugs Report 15 years 8 months ago #2739

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Offline
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
1. - where exactly is the content item link wrong?
2. Do you have any proposal for a better name? Only Other components or what?
3. I will check that.

Bugs Report 15 years 8 months ago #2740

  • Khoa Nguyen
  • Khoa Nguyen's Avatar Topic Author
  • Offline
  • Fresh Boarder
  • Fresh Boarder
  • Posts: 5
  • Thank you received: 0
1. In Administrator, Comment management
2. I have no idea about this. I think I have to play more with the component.

Bugs Report 15 years 8 months ago #2757

  • Khoa Nguyen
  • Khoa Nguyen's Avatar Topic Author
  • Offline
  • Fresh Boarder
  • Fresh Boarder
  • Posts: 5
  • Thank you received: 0
I found 1 more bug, it's maybe critical.
The component import the css file multi times.

<link type="text/css" href="http://www.xipit.com//components/com_comment/joscomment/templates/default-emotop/css/css.css" rel="stylesheet">

This code is inserted for each content item. So, if I have 7 content items. I will have 7 lines.
You can take a look at my website www.xipit.com

Bugs Report 15 years 8 months ago #2763

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Offline
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
Hey thanks! Is your cache on?

Bugs Report 15 years 8 months ago #2765

  • Khoa Nguyen
  • Khoa Nguyen's Avatar Topic Author
  • Offline
  • Fresh Boarder
  • Fresh Boarder
  • Posts: 5
  • Thank you received: 0
No, the cache is off.

Bugs Report 15 years 8 months ago #2802

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Offline
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
The first problem(contentid) is fixed in SVN(took 5h :)). Will look at the css one these days.
Thanks for helping!

Bugs Report 15 years 8 months ago #2803

  • Khoa Nguyen
  • Khoa Nguyen's Avatar Topic Author
  • Offline
  • Fresh Boarder
  • Fresh Boarder
  • Posts: 5
  • Thank you received: 0
Hey, sorry, I cannot find SVN info about JoComment 4.0.
Can you tell where I can get it?

Bugs Report 15 years 8 months ago #2858

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Offline
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081

Bugs Report 15 years 8 months ago #2911

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Offline
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
Ok, I fixed the CSS bug. Look at the repository.

Bugs Report 15 years 8 months ago #3147

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Offline
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
Ok, MTdefault-emotop bug is also fixed.
Find
<script type="text/javascript">
var JOSCmySlide = new Fx.Slide('JOSCMTtexttoogle');
$('JOSCMTstretchertoogleFORM').addEvent('click', function(e){
	e = new Event(e);
	JOSCmySlide.toggle();
	e.stop();
});
</script>
<script type="text/javascript">
	function JOSC_afterAjaxResponse(action) {
		switch(action) {
			case 'show':
			case 'response_reply':
			case 'response_edit':
			case 'response_quote':
				JOSCmySlide.show();
				return 0;
				break;
 
			case 'hide':
			case 'response_editpost':
			case 'response_posted':
			case 'response_approval':
    			JOSCmySlide.hide();
				return 0;
				break;
/* because of bug with IE ...(?)
			case 'response_searchform': 
			case 'response_getcomments':
				JOSCmySlide.show();
                JOSCmySlide.hide();
				return 0;
                break;
*/
			default:
				return 0;
		}
	}
	if (window.document.URL.indexOf("#CommentForm")<0) {
           if (JOSC_is_ie) window.onload = function(){JOSC_afterAjaxResponse("hide");}
           else JOSC_afterAjaxResponse("hide");
    }
</script>  
and change it to
<script type="text/javascript">
var JOSCmySlide = new Fx.Slide('JOSCMTtexttoogle');
document.getElementById('JOSCMTstretchertoogleFORM').addEvent('click', function(e){
	e = new Event(e);
	JOSCmySlide.toggle();
	e.stop();
});
	function JOSC_afterAjaxResponse(action) {
		switch(action) {
			case 'show':
			case 'response_reply':
			case 'response_edit':
			case 'response_quote':
				JOSCmySlide.show();
				return 0;
				break;
 
			case 'hide':
			case 'response_editpost':
			case 'response_posted':
			case 'response_approval':
    			JOSCmySlide.hide();
				return 0;
				break;
/* because of bug with IE ...(?)
			case 'response_searchform': 
			case 'response_getcomments':
				JOSCmySlide.show();
                JOSCmySlide.hide();
				return 0;
                break;
*/
			default:
				return 0;
		}
	}
	if (window.document.URL.indexOf("#CommentForm")<0) {
           if (JOSC_is_ie) window.onload = function(){JOSC_afterAjaxResponse("hide");}
           else JOSC_afterAjaxResponse("hide");
    }
</script>  

dev.compojoom.com/repositories/revision/jocomment/70
  • Page:
  • 1
Time to create page: 0.161 seconds