×

Notice

The forum is in read only mode.
Welcome, Guest
Username: Password: Remember me
  • Page:
  • 1
  • 2

TOPIC: Quotes and apostrophes not escaped correctly

Quotes and apostrophes not escaped correctly 14 years 8 months ago #6236

  • Kian Kian
  • Kian Kian's Avatar
  • Offline
  • Fresh Boarder
  • Fresh Boarder
  • Posts: 11
  • Thank you received: 0
Completely unrelated, another request, which I believe was also mentioned in another forum post a while back.

It would be great if there was a separate permanent RSS feed that contained ALL the comments on various articles, so someone could subscribe to the full comments RSS and read all activity on a site rather than just on one article.

Quotes and apostrophes not escaped correctly 14 years 8 months ago #6237

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
Well, that is not difficult to make, but should be a module not related to the component in any way.

Quotes and apostrophes not escaped correctly 14 years 8 months ago #6238

  • Kian Kian
  • Kian Kian's Avatar
  • Offline
  • Fresh Boarder
  • Fresh Boarder
  • Posts: 11
  • Thank you received: 0
Ah, ok, that makes sense...

Although it could also work as an optional button next to the current RSS link - if someone wanted to use it elsewhere on the site in a module position, they could always copy/paste the static URL for that RSS and insert it as a link...

However, I don't know how many other users would also like this feature.

(this thread has sort of/completely gone off topic, sorry)

Quotes and apostrophes not escaped correctly 14 years 8 months ago #6296

  • JonusC
  • JonusC's Avatar
  • Offline
  • Platinum Boarder
  • Platinum Boarder
  • Posts: 785
  • Thank you received: 48
Kian wrote:

A quick and dirtier fix might be to have both at the same time, which may not require a template rewrite at all (though I'm not sure about that). I.e., if you change the <voting> </voting> block in the php, could it be possible to just display the aggregate of + or - votes before the individual votes?

So you would end up with front-end reading: <normal etc font>+10</font> [red thumbsdown logo] 5 [red thumbsup] 15

Dunno, just thinking out loud...


This is what I originallhad working 100% in my own branch of the codebase. However I had to "clone" every single block of code related to voting and resulting in several new hundred lines of code (because I don't know enough to re-write the existing code, just add conditional branch and alternate code) and even then I couldn't get the AJAX to work right - whenever someone voted on a post, the "-2" would transform from -3 (new combined) back to 5 / 2 (current seperated)

My personal preference would be to ditch the separate numbers completely in favour of a combined +ve or -ve number of some sort, but others may have different views about it.

Exactly the reason why this hasn't become the new default :) I'd prefer a combined method, but others might not. The soon to come Premium Skins will probably contain a combined number and the free "basic" skins will retain the classic mode.

It would be great if there was a separate permanent RSS feed that contained ALL the comments on various articles, so someone could subscribe to the full comments RSS and read all activity on a site rather than just on one article.

That's a good idea for a module :)
  • Page:
  • 1
  • 2
Time to create page: 0.123 seconds