×

Notice

The forum is in read only mode.
Welcome, Guest
Username: Password: Remember me

TOPIC: HotSpots V3 - EDIT function and map problem

HotSpots V3 - EDIT function and map problem 8 years 5 months ago #17073

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
the file is
components/com_hotspots/views/hotspot/tmpl/default.php
not sure which line it was, but just look in the file for the closing </fieldset> tag and there was a place where you had </fieldset> followed by a closing </div> and it should be the other way around.

About the captcha - go to the dashboard -> top right -> options -> security and select the user groups that should see it.

Kind regards,
Daniel

HotSpots V3 - EDIT function and map problem 8 years 5 months ago #17074

  • Torsten Roecker
  • Torsten Roecker's Avatar Topic Author
  • Offline
  • Senior Boarder
  • Senior Boarder
  • Posts: 56
  • Thank you received: 1
Dear Daniel,

I can't find any </fieldset> in components/com_hotspots/views/hotspot/tmpl/default.php :( maybe another file?

Captcha my last description was not clear, when I activate the captcha for Guest or User then it always shows "Code wrong..." and the map is "Loading" instead of going back to location add, when I activate it for Admin-User's for testing then it works. Because of this I thought it cloud be a problem with the folder rights?

Daniel Dimitrov wrote: the file is
components/com_hotspots/views/hotspot/tmpl/default.php
not sure which line it was, but just look in the file for the closing </fieldset> tag and there was a place where you had </fieldset> followed by a closing </div> and it should be the other way around.

About the captcha - go to the dashboard -> top right -> options -> security and select the user groups that should see it.

Kind regards,
Daniel

HotSpots V3 - EDIT function and map problem 8 years 5 months ago #17075

  • Torsten Roecker
  • Torsten Roecker's Avatar Topic Author
  • Offline
  • Senior Boarder
  • Senior Boarder
  • Posts: 56
  • Thank you received: 1
Hi Daniel,

I found 1 problem in /components/com_hotspots/views/form/tmpl/form.php Line 154-156 missing </div> before </fieldset> .
But this has not fixed the problem with the jumping menu :(

Is there a different site for admin <-> user when adding hotspots?
When logged in as admin the site is ok, "send" button ok, description field "line breaks" ok, layout ok.


Many thanks in advance

Torsten

HotSpots V3 - EDIT function and map problem 8 years 5 months ago #17076

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
Good Morning Torsten!

I'm sorry for not pointing you to the correct file (in version 2 I think there was no form view...)

I don't think that the jumping problem is caused by hotspots - yea, it might seem so, but by looking at the source code of your template -> there are a lot of errors. You divs that are not correct, tables etc...

My advise is get this plugin for firefox:
addons.mozilla.org/en-US/firefox/addon/html-validator/

Inspect your page, correct the problems with the template and if the menu is jumping again on the hotspots page I'll have a look.

Cheers,
Daniel

P.S. I'll try to reproduce the captcha problem now.

HotSpots V3 - EDIT function and map problem 8 years 5 months ago #17085

  • Torsten Roecker
  • Torsten Roecker's Avatar Topic Author
  • Offline
  • Senior Boarder
  • Senior Boarder
  • Posts: 56
  • Thank you received: 1
Dear Daniel,

Your right there are a lot of problems with the template (I used html format for the head in the index.php insted of css) I have to fix it soon :oops:

Thanks for the link to HTML-Validator, this is a great tool I have not used before :) And it helped me to fix the jumping menu problem :)
After deleting the head of the template I found the problem caused by HotSpots form.php.

And this has to be done to fix it:

/components/com_hotspots/views/form/tmpl/form.php --> Line 187-189
        </div><!--NEW POSITION FIXED JUMPING MENU-->
<?php endif; ?>
<!--</div>--><!--OLD POSITION-->

Changing this also fixed the captcha problem :)


Another point I don't understand is the line break within the description field...

As logged in user I enter in the description:

Line1
Line2
...

Shown on the map

Line1
Line2
...


As Guest the same while adding an hotspot:

Line1
Line2
...

And shown on the map

Line1 Line2 ...

Any ideas?


Thanks in advance and kind regards Torsten

EDIT: No problem with the file, this can happen :)

Daniel Dimitrov wrote: Good Morning Torsten!

I'm sorry for not pointing you to the correct file (in version 2 I think there was no form view...)

I don't think that the jumping problem is caused by hotspots - yea, it might seem so, but by looking at the source code of your template -> there are a lot of errors. You divs that are not correct, tables etc...

My advise is get this plugin for firefox:
addons.mozilla.org/en-US/firefox/addon/html-validator/

Inspect your page, correct the problems with the template and if the menu is jumping again on the hotspots page I'll have a look.

Cheers,
Daniel

P.S. I'll try to reproduce the captcha problem now.

HotSpots V3 - EDIT function and map problem 8 years 5 months ago #17098

  • Torsten Roecker
  • Torsten Roecker's Avatar Topic Author
  • Offline
  • Senior Boarder
  • Senior Boarder
  • Posts: 56
  • Thank you received: 1
Hi and good morning Daniel,

I've found another problem with the above form.php

IE 8 Add Hotspot Map stays gray

to fix this I've changed:
$domready = <<<ABC
window.addEvent('domready', function() {
	hotspots = new compojoom.hotspots.core();

to
$domready = <<<ABC
window.addEvent('domready', function() {
	var hotspots = new compojoom.hotspots.core();


Kind regards Torsten

HotSpots V3 - EDIT function and map problem 8 years 5 months ago #17101

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
Hey Torsten,
Thanks! This is already fixed in my dev. version and I most probably will push all my changes so far today in the dev. area .

Where do you see the problem with the description area? In single view? Or when you open an infowindow?

Kind regards,
Daniel

HotSpots V3 - EDIT function and map problem 8 years 5 months ago #17103

  • Torsten Roecker
  • Torsten Roecker's Avatar Topic Author
  • Offline
  • Senior Boarder
  • Senior Boarder
  • Posts: 56
  • Thank you received: 1
Hi Daniel,

I can see it in the single view and the info window.

When you have a look at the two hotspots in France: MAP
one was created by Guest and one by Logged in User.

Kind regards
Torsten

HotSpots V3 - EDIT function and map problem 8 years 5 months ago #17104

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
Hey Torsten,
It is not a bug! It is a feature :)

User input has to be filtered - this way we can ensure that no malicious code will be injected in your page. Since the default rule is - never trust user input - this is what we do as well :)

There is a global feature in Joomla to parse the input text and filter it. You can find the configuration by going to site -> global config -> text filters. There you have to define what text filters should be applied to each user group (the administrator has none, and that is why the <p> tags are not stripped out when saved).

You can set a blacklist for example and it should work. I would actually go for a white list and enable things such as p, i, b, span etc. Only the things that a user needs to enter in order for the hotspot to be properly formatted.

Cheers,
Daniel

HotSpots V3 - EDIT function and map problem 8 years 5 months ago #17105

  • Torsten Roecker
  • Torsten Roecker's Avatar Topic Author
  • Offline
  • Senior Boarder
  • Senior Boarder
  • Posts: 56
  • Thank you received: 1
Dear Daniel,

you're completely right. I had this not in my mind :oops: Sorry for bothering you with this :(

Kind regards Torsten

HotSpots V3 - EDIT function and map problem 8 years 5 months ago #17109

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
don't worry! Do you think that you can test the latest dev release:
compojoom.com/downloads/developer-releas...y-stuff/dev-hotspots

this is 3.0, but with the described bug fixes. I still need to fix some things related to the search and I'll release 3.0.1 next week.

Daniel

HotSpots V3 - EDIT function and map problem 8 years 5 months ago #17110

  • Torsten Roecker
  • Torsten Roecker's Avatar Topic Author
  • Offline
  • Senior Boarder
  • Senior Boarder
  • Posts: 56
  • Thank you received: 1
Hi Daniel,

I'm running akeeba backup at the moment after this I'll install and test the dev release :)

Kind regards Torsen

Daniel Dimitrov wrote: don't worry! Do you think that you can test the latest dev release:
compojoom.com/downloads/developer-releas...y-stuff/dev-hotspots

this is 3.0, but with the described bug fixes. I still need to fix some things related to the search and I'll release 3.0.1 next week.

Daniel

HotSpots V3 - EDIT function and map problem 8 years 5 months ago #17117

  • Torsten Roecker
  • Torsten Roecker's Avatar Topic Author
  • Offline
  • Senior Boarder
  • Senior Boarder
  • Posts: 56
  • Thank you received: 1
Hi Daniel,

I've installed the new Dev release and it's working very well at the moment :)

I've found on problem in the Dev release code (I've fixed this in the V3 this morning):

Torsten Roecker wrote: Hi and good morning Daniel,

I've found another problem with the above form.php

IE 8 Add Hotspot Map stays gray

to fix this I've changed:

$domready = <<<ABC
window.addEvent('domready', function() {
	hotspots = new compojoom.hotspots.core();

to
$domready = <<<ABC
window.addEvent('domready', function() {
	var hotspots = new compojoom.hotspots.core();


Kind regards Torsten


Do you think there will be an change in the code to auto close the slide menu in V 3.0.1 or may be the possibility to select "keep closed until user opens" through the backend?


Kind regards Torsten

HotSpots V3 - EDIT function and map problem 8 years 5 months ago #17120

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
You are right... Again - you wrote form and I only thought about the hotspot view... Ok, so I've corrected the form view as well now. Thanks!

Yep, chances are pretty high that once the user closes the menu it will stay closed in next version.

Cheers,
Daniel

HotSpots V3 - EDIT function and map problem 8 years 5 months ago #17121

  • Torsten Roecker
  • Torsten Roecker's Avatar Topic Author
  • Offline
  • Senior Boarder
  • Senior Boarder
  • Posts: 56
  • Thank you received: 1
Dear Daniel,

maybe also to keep the menu closed on loading the map ;)

Daniel Dimitrov wrote:
Yep, chances are pretty high that once the user closes the menu it will stay closed in next version.

Cheers,
Daniel

HotSpots V3 - EDIT function and map problem 8 years 5 months ago #17170

  • Torsten Roecker
  • Torsten Roecker's Avatar Topic Author
  • Offline
  • Senior Boarder
  • Senior Boarder
  • Posts: 56
  • Thank you received: 1
Dear Daniel,

I've installed and tested all Dev releases since end of last week and what to tell... it's running great :)

I've only found one "problem" with Firefox and mouse wheel zoom / page scroll.
If the Firefox window size is smaller than the page and the page scroll is activated the map zoom is working but the page is also scrolling up / down (this problem is only with ff, chrome/ie are ok).
Regarding this I've found an similar problem and workaround there, but I don't know where to add the code: http://code.google.com/p/gmaps-api-issues/issues/detail?id=3652

And one question, is there a way to add an own Google APIv3 Key?


Kind regards Torsten

HotSpots V3 - EDIT function and map problem 8 years 5 months ago #17171

  • Eliecer Marchante
  • Eliecer Marchante's Avatar
  • Offline
  • Platinum Boarder
  • Platinum Boarder
  • Posts: 493
  • Karma: 11
  • Thank you received: 13
As far as I know, you don't need a key to use Google Maps API v3, but I could be wrong.

HotSpots V3 - EDIT function and map problem 8 years 5 months ago #17172

  • Torsten Roecker
  • Torsten Roecker's Avatar Topic Author
  • Offline
  • Senior Boarder
  • Senior Boarder
  • Posts: 56
  • Thank you received: 1
Dear Eliecer,

there is no need to use an API Key in V3. But with an API Key there are extended monitoring functions :)

HotSpots V3 - EDIT function and map problem 8 years 5 months ago #17173

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Away
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
Hey Torsten,
Can you point me to some information about the api key - I saw it that you are supposed to create one now, but I didn't understand whatfor.

To add your api key right now you'll have to make a template override of each layout and just add it to the google url.

Regards,
Daniel

HotSpots V3 - EDIT function and map problem 8 years 5 months ago #17174

  • Torsten Roecker
  • Torsten Roecker's Avatar Topic Author
  • Offline
  • Senior Boarder
  • Senior Boarder
  • Posts: 56
  • Thank you received: 1
Dear Daniel,

I wanted to monitor how many connections are establish by my site to prevent getting blocked :(
Perhaps I make too many thoughts myself...

It was only an idea I had this morning and not really important :)


Any idea regarding the Firefox issue?


Kind regards Torsten
Time to create page: 0.234 seconds