×

Notice

The forum is in read only mode.
Welcome, Guest
Username: Password: Remember me
  • Page:
  • 1
  • 2

TOPIC: MyTemplate: MT-DoubleSlide (need help with bugs)

MyTemplate: MT-DoubleSlide (need help with bugs) 15 years 7 months ago #3221

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Offline
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
Could you zip the folder and upload it here. This way I can work on all your files.

MyTemplate: MT-DoubleSlide (need help with bugs) 15 years 7 months ago #3222

  • Helly
  • Helly's Avatar Topic Author
  • Offline
  • Junior Boarder
  • Junior Boarder
  • Posts: 29
  • Thank you received: 8

MyTemplate: MT-DoubleSlide (need help with bugs) 15 years 7 months ago #3224

  • Helly
  • Helly's Avatar Topic Author
  • Offline
  • Junior Boarder
  • Junior Boarder
  • Posts: 29
  • Thank you received: 8
update : found another bug: I can not change the comment when i press edit

also added it in the top post.

HELLY

MyTemplate: MT-DoubleSlide (need help with bugs) 15 years 7 months ago #3233

  • Helly
  • Helly's Avatar Topic Author
  • Offline
  • Junior Boarder
  • Junior Boarder
  • Posts: 29
  • Thank you received: 8
As it seems theire has been a problem with the archive. The index page wasnt updated like it should be.

http://bartos.dommel.be/

the ZIP has been updated
apologies.

MyTemplate: MT-DoubleSlide (need help with bugs) 15 years 7 months ago #3236

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Offline
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
Ok, I made some changes. Please use single quotes instead of double ones.

first thing - library path was wrong.
second thing - you had to move the library tags position. You want to include javascript that examines the form, if you add it before the form, then it is not going to work.


There is no margin problem on my configuration (joomla 4.0 nearly beta 1 :))
use this configuration svn.compojoom.com/jocomment/trunk/
(for the changes that I made to your template look the attached file)

What I see now is that I will have to rewrite the old templates and fix the js code in the client file.

If you use the new template syntax, then there are no margin problem(comment indent), but the js is expecting a table in the script and that is a problem.
So the new release will have to wait.
I want everything to be perfect. myMTSlideBoth_emotop.zip

MyTemplate: MT-DoubleSlide (need help with bugs) 15 years 7 months ago #3239

  • Helly
  • Helly's Avatar Topic Author
  • Offline
  • Junior Boarder
  • Junior Boarder
  • Posts: 29
  • Thank you received: 8
Oke, Thanks allready.

If theire is something i can help with. Just feel free to tell me. My company's site is in a hurry with this template alltough the normal commentary works just fine atm. Without the sliders.
So if you need help just ask :)

Helly

MyTemplate: MT-DoubleSlide (need help with bugs) 15 years 7 months ago #3253

  • Helly
  • Helly's Avatar Topic Author
  • Offline
  • Junior Boarder
  • Junior Boarder
  • Posts: 29
  • Thank you received: 8
So basicly i need to install 4.0 now ? or just edit the comment.class.php ?

gonna work on the JS code so it expects div's instead of tables.

:EDIT:
Slider doesnt work when NOT logged in.
it does work when i put the require users to log in to post when i disable it

helly

MyTemplate: MT-DoubleSlide (need help with bugs) 15 years 7 months ago #3261

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Offline
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
Yes, please work on 4.0

MyTemplate: MT-DoubleSlide (need help with bugs) 15 years 7 months ago #3325

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Offline
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
Ok, here is the new jscript.js looking for ul and li instead of table and tbody client.zip

MyTemplate: MT-DoubleSlide (need help with bugs) 15 years 7 months ago #3326

  • Helly
  • Helly's Avatar Topic Author
  • Offline
  • Junior Boarder
  • Junior Boarder
  • Posts: 29
  • Thank you received: 8
thx , gonna try it right away

: edit :

The form isnt displayed anymore now. only different Client.js
do i need to adjust my template file or ?
just odd that i cant seem to display it anymore.

:edit 2:

fixed error
now 2nd error when i post message

Character problem. empty comment

and when i try to remove i get a 2nd pop wich is empty.
im really trying to lose it right now :D

MyTemplate: MT-DoubleSlide (need help with bugs) 15 years 7 months ago #3337

  • Helly
  • Helly's Avatar Topic Author
  • Offline
  • Junior Boarder
  • Junior Boarder
  • Posts: 29
  • Thank you received: 8
think this requires a reply:

When i set one setting active (random one) ex: change the smiley pack. The extension deletes all my code ( the custom template) and leaves 1 big empty template page.

Im am swimming in a bucket of riddles now and i cant figure them out :(

MyTemplate: MT-DoubleSlide (need help with bugs) 15 years 7 months ago #3339

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Offline
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
Hm, funny - your template is there for me.
I will try to pack my development version of the extension so you can give it a try.

MyTemplate: MT-DoubleSlide (need help with bugs) 15 years 7 months ago #3340

  • Helly
  • Helly's Avatar Topic Author
  • Offline
  • Junior Boarder
  • Junior Boarder
  • Posts: 29
  • Thank you received: 8
thanks in advance allready for the quick replys

MyTemplate: MT-DoubleSlide (need help with bugs) 15 years 7 months ago #3349

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Offline
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
Hey there!
Here is the development version I promised you!

Please don't do anything under backend->components->!joomlacomment->advertisement .

This is my dev. version and the feature is still not ready.

I fixed your template. Both slides are working for me. The form is closed and you have to click to open it and the comments are open, but after clicking on the +- sign they close :)

I added also the images from the other templates. Please decide which emoticons you want to use and which not and then give us your template so we can include in the next joomlacomment version.

Thank you in advance! jocomment4-29bb36b8eb3b5bfe70a4ae19aad08fcf.zip


edit: If for some reason the component doesn't install, please report the error to me.

MyTemplate: MT-DoubleSlide (need help with bugs) 15 years 7 months ago #3350

  • Helly
  • Helly's Avatar Topic Author
  • Offline
  • Junior Boarder
  • Junior Boarder
  • Posts: 29
  • Thank you received: 8
Hi daniël,

Thanks for fixing almost all bugs. At the moment we are having issues with our testsite (some folder got missing), we are resolving this matter asap.
So i tried it in my test site (local webserver one) and guess what. It all worked out. it all works.
Theire is still 1 little bug in it:

when you slide the form and then press reply, the form dissapears. i will look into this matter. At the moment our testsite (remote) has some priority cause of other things working on that one.

I allready want to thank you. and yes you may use it in the next release of the JoomlaComment , open source matters !:laugh:
(would like my name in the template or something :p )

:edit:
can all emoticons be included or ?

greetings
helly

MyTemplate: MT-DoubleSlide (need help with bugs) 15 years 7 months ago #3351

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Offline
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
Which emoticons? If you want to use your custom emoticons with your template you will have to give me them also :)

MyTemplate: MT-DoubleSlide (need help with bugs) 15 years 7 months ago #3352

  • Helly
  • Helly's Avatar Topic Author
  • Offline
  • Junior Boarder
  • Junior Boarder
  • Posts: 29
  • Thank you received: 8
aha , i'm not using that. So will use the standard ones the extension has supplied.

MyTemplate: MT-DoubleSlide (need help with bugs) 15 years 7 months ago #3353

  • Helly
  • Helly's Avatar Topic Author
  • Offline
  • Junior Boarder
  • Junior Boarder
  • Posts: 29
  • Thank you received: 8
At the moment checking the extension (fixed our remote server thank god :D )

bugs ive found so far:

- Send button keeps on being displayed half
- After a reply , slide the commens the entire forms slide in and when sliding out the comment form comes out displayed vor 25%

TODO for me:

- put all code via unobtrusive class (based on my friends examples). (think is gonna solve the send button problems & the sliders)

UPDATE will come this noon (i hope)

MyTemplate: MT-DoubleSlide (need help with bugs) 15 years 7 months ago #3397

  • Helly
  • Helly's Avatar Topic Author
  • Offline
  • Junior Boarder
  • Junior Boarder
  • Posts: 29
  • Thank you received: 8
UPDATE TIME:

FIXES:

Send button has been fixed. Reason : mootools bug, worked around it

BIG UPDATE:

Sliders / togglers are now in unobtrusive code wich means
all sliders and all togglers are theire respective arrays.

TODO:

- make auto hide via parameters.
- upload the template OFC for you Daniël
- getting the template approved (hopefully with credits :D )
- write a notepad.

MyTemplate: MT-DoubleSlide (need help with bugs) 15 years 7 months ago #3398

  • Daniel Dimitrov
  • Daniel Dimitrov's Avatar
  • Offline
  • Administrator
  • Administrator
  • Posts: 9618
  • Karma: 155
  • Thank you received: 1081
Don't worry :)
Your template is already approved :) just make it work :)
Write your credits in the template - I will not delete them - of course :)
  • Page:
  • 1
  • 2
Time to create page: 0.147 seconds