Joomla Components and Professional Joomla Templates

I've been having problems with the Module giving incorrect links (back to the home page rather than article) when listing most commented. I'm using sh404sef and tried all the fixes mentioned on the board without luck.

I then got digging in the code and found there is an error in line 80 of mod_comments.class.php

It should read
$id = $row['contentid'];
not
$id = $row['id'];


I hope this helps.

which joomlacomment version are you using 4.0RC1 ?

Yes, but this error is in the module. I'm using a recent version of the module that you provided on the forum in response to as question.

I checked the contents of the array being passed to the module and it didn't include id, just contentid.

I've tested the fix and it works.

If you look carefully at the module code you will find out that we use code from the component. That is why I asked you if you use RC1.

I realise that. I know that the link is formed in josc_com_content.class.php. But it is the module that wasn't working because the information wasn't being passed correctly.

I do like your product though and I'm posting this to help not to criticise.

Hey Andrew,
I'm not assuming that you are criticizing - I just want to know which version of joomlacomment you are using. I can not remember all the things I've changed to the component. So perhaps this is something solved in RC1. This is why I am asking you if you use the latest version or not.

Sorry, my initial answer was unclear. I did say yes to using RC1 but I can see that wasn't obvious.

Ah good. I'll check it out then, but I have this strange feeling that if I make your change, that it won't work for all other plugins

But the change is only to the module, it doesn't alter the component.

But yes, knock-on effects would not be good!

Forgive me if I missed something, but this makes no sense to me. contentid returns Undefined Index error and the entire module breaks. Please tell us your Joomla version, PHP version and MySQL version, and if you have ever installed any other commenting components as there may be lingering (yComments, JomComment, JComments, etc)

Also tell us if you have done any upgrading on this site (Joomla 1.0 > 1.5, or JoomlaComment 3.26 > 4.0, etc.)

Daniel did you actually try the "fix" in the original post?

EDIT: Do you have one of the outdated versions of sh404SEF installed (all the ones that were free) or are you up to date (paid versions)? If you're up to date please make a screen dump of your settings and I will compare to mine, I can put this in a FAQ about JoomlaComment or sh404SEF.